GCP Transformer and create_and_reproject warp.#177
Open
michaeljfazio wants to merge 1 commit intogeorust:masterfrom
Open
GCP Transformer and create_and_reproject warp.#177michaeljfazio wants to merge 1 commit intogeorust:masterfrom
michaeljfazio wants to merge 1 commit intogeorust:masterfrom
Conversation
michaeljfazio
force-pushed
the
gcp-transform
branch
2 times, most recently
from
eba90c9 to
6378737
Compare
michaeljfazio
force-pushed
the
gcp-transform
branch
from
6378737 to
5561935
Compare
Author
|
Fixed all clippy issues. Should be good to go now. |
lnicola
reviewed
Sep 12, 2021
| gdal_sys::GDALCreateAndReprojectImage( | ||
| src.c_dataset(), | ||
| null(), | ||
| CString::new(psz_dst_filename)?.as_ptr(), |
Member
There was a problem hiding this comment.
This is a use-after-free: the CString is destroyed before GDALCreateAndReprojectImage runs.
metasim
requested changes
Sep 21, 2022
| /// # Examples | ||
| /// | ||
| /// ```no_run | ||
| /// use std::path::Path; |
Contributor
There was a problem hiding this comment.
Does rustdoc still compile this without rust in fence suffix. i.e. does this need to be rust, no_run?
| /// use gdal::Dataset; | ||
| /// use gdal::alg::transform::Transformer; | ||
| /// | ||
| /// let path = Path::new("/path/to/dataset"); |
Contributor
There was a problem hiding this comment.
Can we use a file in fixtures to demo this? If no, can we construct a very small example file with GCPs and save it there?
| } | ||
|
|
||
| impl Transformer { | ||
| /// Construct a ```Transformer``` from a valid C GDAL pointer to a transformer instance. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Construct a ```Transformer``` from a valid C GDAL pointer to a transformer instance. | |
| /// Construct a [`Transformer`] from a valid C GDAL pointer to a transformer instance. |
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// * `dataset` - The `Dataset` to extract Ground Control Points from. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// * `dataset` - The `Dataset` to extract Ground Control Points from. | |
| /// * `dataset` - The [`Dataset`] to extract Ground Control Points from. |
| ) -> Result<()> { | ||
| let psz_dst_filename = dst_path | ||
| .to_str() | ||
| .expect("Destination path must be supplied."); |
Contributor
There was a problem hiding this comment.
Won't this panic? Can you return an Err instead?
| let psz_dst_filename = dst_path | ||
| .to_str() | ||
| .expect("Destination path must be supplied."); | ||
| let psz_dst_wkt = dst_srs.to_wkt().expect("Failed to obtain WKT for SRS."); |
| }; | ||
|
|
||
| gdal_sys::GDAL_GCP { | ||
| pszId: CString::new(p.id.clone()).unwrap().into_raw(), |
Contributor
There was a problem hiding this comment.
Is this use after free?
Instead of unwrap, should an Err be returned?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This change adds a wrapper for the GDAL Transformer abstraction. An initial implementation of the GCP based polynomial transformer has also been added. Future versions should look to extend the Transformer abstraction to include other implementations such as:
Also included in the change set is an implementation of GDALCreateAndReprojectImage function.