test(postgis): replace ignored tests with env-based skip#282
Open
herostrat wants to merge 1 commit intogeorust:mainfrom
Open
test(postgis): replace ignored tests with env-based skip#282herostrat wants to merge 1 commit intogeorust:mainfrom
herostrat wants to merge 1 commit intogeorust:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdI removed blanket ignore usage for PostGIS integration tests and switched to environment-aware execution.
This is done by adding a shared runtime skip helper that skips only when DATABASE_URL is missing, updated CI to run the PostGIS test target directly, and documented the behavior in the README.
I changed this to keeps local developer workflows smooth while making CI behavior explicit and deterministic, improving test maintainability and reducing hidden test coverage gaps.