Adding reminder for inclusive pronouns Issue #297#345
Open
jfreud1 wants to merge 1 commit intoget-alex:mainfrom
Open
Adding reminder for inclusive pronouns Issue #297#345jfreud1 wants to merge 1 commit intoget-alex:mainfrom
jfreud1 wants to merge 1 commit intoget-alex:mainfrom
Conversation
Member
|
Thanks for your PR and your patience! That issue is open because I have feedback on it that has not been addressed by the original poster. To recap: it sounds like the user knows perfectly well what to do. I am not sure this feature is needed. More here: #297 (comment). I am not sure a message is needed for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #297
This implementation is for the second solution proposed in the issue "More Helpful Response to He/Her Pronouns"
Let us know what you think! Our changes were made to index.js
this function is intended to remind the user to confirm the proper pronouns of the subjects in the text when pronouns are detected