feat: should redirect param#207
Closed
cth-latest wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I tried this I do not know why i still get this LOG error [NotSupportedError: Cannot set "location.href".] |
Member
|
Note: this is specifically affecting Expo SDK 53 users, where wiindow.location is now polyfilled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve issue #206.
Previously, the code attempted to detect a React Native environment by checking if
window.location === undefined. However, this condition evaluates totrueeven in a React Native application (tested with Expo & Expo Router).This PR introduces an optional
shouldRedirectparameter, allowing it to be explicitly set tofalse. It defaults totrue, ensuring this change is non-breaking.This PR was trying to solve the problem some moths ago #160 (while adding some unwanted reformatting)
If someone could merge this ASAP would be great as the library is actually completely unusable on React Native for OAuth.
@thomasballinger @xixixao