Remove portpicker dependency, use direct port binding#405
Open
mvanhorn wants to merge 1 commit intoget-convex:mainfrom
Open
Remove portpicker dependency, use direct port binding#405mvanhorn wants to merge 1 commit intoget-convex:mainfrom
mvanhorn wants to merge 1 commit intoget-convex:mainfrom
Conversation
Replace the last remaining portpicker usage in subs/mod.rs with
TcpListener::bind("127.0.0.1:0"), matching the pattern already
used in node_executor/src/local.rs. Remove the portpicker dependency
from workspace, local_backend, and application Cargo.toml files.
portpicker is unmaintained (last updated 4 years ago) and fails on
servers without IPv6 support.
Relates to get-convex#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #72
Removes the
portpickercrate dependency entirely by replacing its last usage withTcpListener::bind("127.0.0.1:0")- the same pattern already used incrates/node_executor/src/local.rs.Changes
crates/local_backend/src/subs/mod.rs: Replaceportpicker::pick_unused_port()withTcpListener::bind("127.0.0.1:0")to get an OS-assigned portCargo.toml: Removeportpicker = "0.1"from workspace dependenciescrates/local_backend/Cargo.toml: Removeportpickerdependencycrates/application/Cargo.toml: Remove unusedportpickerdependencyWhy
The
portpickercrate is unmaintained (last updated 4+ years ago) and fails on servers without IPv6 support, causing the "No ports free" crash reported in #72. The production crash path inlocal.rswas already fixed to use direct port binding - this PR completes the cleanup by removing the last usage and the dependency itself.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This contribution was developed with AI assistance (Claude Code).