fix: polyfill Buffer for AWS request signing in V8 - #76
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: get-convex/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe package adds Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hello convex friends, this fixes #62.
Some AWS SDK versions allowed by the component’s dependency range require a global
Bufferduring SigV4 signing. Convex’s default V8 runtime does not provide one, causing R2 operations such as metadata synchronization to fail after an upload reaches the bucket.This adds the browser-compatible
bufferpackage at the shared R2 client boundary and regression coverage in the repository’s Edge-runtime test environment.