fix(models,engine): persist solo per-load overrides across restart; kv fp8 off for multimodal#51
Merged
Merged
Conversation
…efault kv fp8 off for multimodal Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two fp8/override defects found live on the 0.5.0 fleet, plus a small AutoData report polish.
config.json, which never received per-load overrides (feat(launch): served-model-name aliases + per-load config overrides #41 persisted them only to the stacked-instance manifest) — a VLM loaded withkv_cache_dtype=autocame back after restart on fp8 and produced corrupted output. Every solo load now persists the full override set to NodeConfig, with absent fields reset to defaults (no cross-load inheritance)._resolved_overrides()applied to the actual launch config, with regression tests inspecting the real backend object. Also fixed the live-vs-persisted divergence on same-model reloads.vision_config/ VL architectures in the local config.json) tokv_cache_dtype=auto. Explicit operator fp8 is still honored via a newkv_cache_dtype_explicitprovenance flag. Not-yet-downloaded repo-ids keep the fp8 default (documented ceiling).best_lift/best_score/best_significant.639 passed, 1 xfailed; ruff clean. Review-gated (1 blocker + 2 majors found, all fixed with regression tests).
🤖 Generated with Claude Code
https://claude.ai/code/session_017NziXzqT1L9kj2T1byA3Ak