Skip to content

feat: universal environment dashboard#2241

Open
kmendell wants to merge 1 commit intomainfrom
feat/universal-dash
Open

feat: universal environment dashboard#2241
kmendell wants to merge 1 commit intomainfrom
feat/universal-dash

Conversation

@kmendell
Copy link
Copy Markdown
Member

@kmendell kmendell commented Apr 6, 2026

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

image

Fixes: #2142

Changes Made

Testing Done

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe):
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR implements a new "universal environment dashboard" view that aggregates data across all configured environments. The backend adds a GetEnvironmentsOverview aggregate endpoint that concurrently fetches per-environment snapshots with proper concurrency limits and timeouts, alongside new types and tests. The frontend adds a new dashboard-all-environments-view.svelte component and restructures the dashboard page to support an "all" vs "current" tab view.

Confidence Score: 5/5

Safe to merge — no blocking issues found; all prior review concerns have been addressed.

The critical bugs flagged in previous rounds (auth scheme mismatch, disabled-environment double-counting, magic string) are all resolved. The new backend logic is well-tested and the frontend progressive-loading pattern is sound. The only remaining finding is the unused getDashboardEnvironmentsOverview service method, which is P2 and does not affect correctness.

frontend/src/lib/services/dashboard-service.ts — the getDashboardEnvironmentsOverview method is dead code unless there is an intended consumer not yet in this PR.

Fix All in Codex

Prompt To Fix All With AI
This is a comment left during a code review.
Path: frontend/src/lib/services/dashboard-service.ts
Line: 33-36

Comment:
**`getDashboardEnvironmentsOverview` is never called**

This method is defined here but not imported or called anywhere in the frontend — `dashboard-all-environments-view.svelte` fetches snapshots per-environment via `getDashboardForEnvironment` instead. The corresponding backend endpoint (`/dashboard/environments`) is therefore unreachable from the UI. If the aggregate endpoint is intended for future use or external API consumers, that's fine, but if the plan was for this view to use it, the wiring is missing.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (2): Last reviewed commit: "feat: universal environment dashboard" | Re-trigger Greptile

Copy link
Copy Markdown
Member Author

kmendell commented Apr 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kmendell
Copy link
Copy Markdown
Member Author

kmendell commented Apr 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@getarcaneappbot
Copy link
Copy Markdown
Contributor

getarcaneappbot commented Apr 6, 2026

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/arcane:pr-2241
  • Agent: ghcr.io/getarcaneapp/arcane-headless:pr-2241

Built from commit ca88e44

@kmendell
Copy link
Copy Markdown
Member Author

kmendell commented Apr 6, 2026

@greptileai

@kmendell kmendell force-pushed the feat/universal-dash branch 11 times, most recently from 6e5a2c4 to 708ede9 Compare April 9, 2026 21:02
@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed.

@kmendell kmendell force-pushed the feat/universal-dash branch from 708ede9 to b711f12 Compare April 10, 2026 22:08
@kmendell kmendell force-pushed the feat/universal-dash branch 3 times, most recently from 8c21173 to 40df004 Compare April 11, 2026 01:38
@kmendell kmendell marked this pull request as ready for review April 11, 2026 01:38
@kmendell kmendell requested a review from a team April 11, 2026 01:38
@kmendell kmendell force-pushed the feat/universal-dash branch 4 times, most recently from 117794a to cc1650d Compare April 12, 2026 18:57
@kmendell kmendell force-pushed the feat/universal-dash branch from cc1650d to 0b00872 Compare April 13, 2026 03:52
@kmendell kmendell force-pushed the feat/universal-dash branch from 0b00872 to ca88e44 Compare April 13, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚡️ Feature: Overall-Dashboard

2 participants