[skip-runtime-e2e] feat(status): rename tenant_id label to client_id (v9 terminology)#73
Merged
Merged
Conversation
v9 Workstream C — terminology rebrand of user-facing `tenant_id` label to `client_id` per axonflow-enterprise#2230. Cosmetic only: - scripts/status.sh prints `client_id: cs_… (formerly tenant_id)` - README install-flow updated to reference `client_id` - README notes Stripe checkout custom field is still labeled "Your AxonFlow tenant ID" (form-side rename happens separately) Compat preserved: - ~/.config/axonflow/try-registration.json JSON key stays `tenant_id` (file-format compat for installed base) - Wire-level `X-Axonflow-Client` header unchanged - Agent-side MCP tool `axonflow_get_tenant_id` keeps its name Tests: - new tests/test-status-client-id-label.sh asserts the 5 invariants (client_id label present, tenant_id label absent, bridge note present, JSON key compat, upgrade-hint phrasing) and is wired into .github/workflows/test.yml - existing 51 hook regression tests pass unchanged Refs axonflow-enterprise#2230, axonflow-enterprise#2255 Signed-off-by: Saurabh Jain <saurabhjain1592@gmail.com>
Companion fix for the v1.5.0 terminology rebrand. The install-smoke harness greps the status output for the labeled line; that assertion needed updating to match the new `client_id:` label introduced in the parent commit. Mirrors the v9 terminology rebrand contract verified by tests/test-status-client-id-label.sh. Refs axonflow-enterprise#2230, axonflow-enterprise#2255 Signed-off-by: Saurabh Jain <saurabhjain1592@gmail.com>
saurabhjain1592
changed the title
Title edit alone doesn't fire pull_request 'synchronize' events, so the Definition-of-Done workflow re-evaluation needs a new commit on the branch. Empty commit serves that purpose without functional change. Refs axonflow-enterprise#2230, axonflow-enterprise#2255 Signed-off-by: Saurabh Jain <saurabhjain1592@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v9 Workstream C — terminology rebrand of user-facing
tenant_idlabel toclient_id. Cosmetic only; no config change required, file format unchanged, wire unchanged.scripts/status.shoutput:tenant_id:→client_id:with bridge note(formerly tenant_id)client_idParent epic: getaxonflow/axonflow-enterprise#2230
Tracking: getaxonflow/axonflow-enterprise#2255
Compat preserved
~/.config/axonflow/try-registration.jsonJSON key STAYStenant_id(file-format compat for installed base)X-Axonflow-Clientheader unchanged (scripts/client-header.sh untouched)axonflow_get_tenant_idkeeps its name (callable both as "what's my tenant ID?" and "what's my client ID?")(formerly tenant_id)in status output for v1.4.x users — removable in v1.6.0Test plan
bash tests/test-hooks.sh— 51/51 pass unchangedbash tests/test-status-client-id-label.sh— 5/5 pass.github/workflows/test.ymlclient_id:→tenant_id:in scripts/status.sh; confirmed 2 test assertions FAILed; restoredAction required for users with scripted output parsing
If your tooling greps for
tenant_id:inscripts/status.shstdout, update toclient_id:(or read~/.config/axonflow/try-registration.jsondirectly).Skip-runtime-e2e justification
This PR is a terminology rebrand only — no new runtime feature surface, no protocol change, no new wire behavior. The implementation surface is:
tenant_id→client_id)try-registration.jsonand asserts the contract invariants:(formerly tenant_id)presenttenant_idpreserved (file-format compat)The wire-level surface (
X-Axonflow-Clientheader,scripts/client-header.sh, MCP toolaxonflow_get_tenant_id) is intentionally untouched — confirmed by reading existing wire-shape-contract.yml workflow and the unchanged client-header tests.There is nothing meaningful for a
runtime-e2e/<feature>/test to exercise against a live agent for this PR class: the agent never sees, parses, or emits the label string — it only handles the value. Adding a runtime-e2e test for terminology rebrand would create test surface area without proof value.4-up cross-plugin coherence (manual R2 verification): captured at
/tmp/v9-plugins-<UTC>/4up.txt. Mutation tests prove assertions are not tautological. R3 hostile self-review at/tmp/v9-plugins-<UTC>/r3.md. Both/tmp/artifacts per project policy of not committing EVIDENCE dirs to git (seefeedback_evidence_bundles_never_in_git.md).Per
reference_skip_runtime_e2e_pr_marker.md: this PR class — regression fixes / test adds / refactors with no new feature surface — is exactly when to use the[skip-runtime-e2e]marker.