Skip to content

Feature/hotfix markdown fences - #1885

Open
Flamenco wants to merge 3 commits into
getgrav:developfrom
Flamenco:feature/hotfix_markdown_fences
Open

Feature/hotfix markdown fences#1885
Flamenco wants to merge 3 commits into
getgrav:developfrom
Flamenco:feature/hotfix_markdown_fences

Conversation

@Flamenco

Copy link
Copy Markdown

Address issues from closed PR

@mahagr

mahagr commented Feb 26, 2018

Copy link
Copy Markdown
Member

@Flamenco Could you add link to the issue that was fixed?

@Flamenco

Copy link
Copy Markdown
Author

fixes #1840

@mahagr

mahagr commented Mar 2, 2018

Copy link
Copy Markdown
Member

Thank you.

@rhukster

rhukster commented Mar 9, 2018

Copy link
Copy Markdown
Member

I think you forgot to commit the language file? Should update the languages/en.yaml file to get the base language strings in there.

@Flamenco

Copy link
Copy Markdown
Author

@rhukster

Copy link
Copy Markdown
Member

BTW @Flamenco does this still work with latest Parsedown updates? Seems the 1.7.0+ releases have broken some more advanced markdown things.

@Flamenco

Copy link
Copy Markdown
Author

It should. It just escapes things so they are not treated as markdown. And then puts them back after calling the pre-processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants