Skip to content

fix(endpoint-micropub): throw a clear error reading posts without a database #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmdes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(endpoint-micropub): throw a clear error reading posts without a database #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/endpoint-micropub/lib/post-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ export const postData = {
const query = { "properties.url": url };
const postsCollection = application?.collections?.get("posts");

if (!postsCollection) {
throw IndiekitError.notImplemented(
"Reading, updating, deleting and restoring posts requires a database",
);
}

const data = await postsCollection.findOne(query);
if (!data) {
throw IndiekitError.notFound(url);
Expand Down
10 changes: 10 additions & 0 deletions packages/endpoint-micropub/test/unit/post-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,16 @@ describe("endpoint-micropub/lib/post-data", async () => {
assert.equal(result.properties.url, url);
});

it("Throws reading post data without a database", async () => {
await assert.rejects(
postData.read({ ...application, collections: undefined }, url),
{
message:
"Reading, updating, deleting and restoring posts requires a database",
},
);
});

it("Updates post by adding properties", async () => {
const operation = { add: { syndication: ["https://website.example"] } };
const result = await postData.update(
Expand Down