Skip to content

fix(preset-eleventy): write posts where the advertised URL resolves #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rmdes wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(preset-eleventy): write posts where the advertised URL resolves #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/preset-eleventy/lib/post-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const getPostTypes = (postTypes) => {
postTypes.set(type, {
...postTypes.get(type),
post: {
path: `${collection}/{yyyy}-{MM}-{dd}-{slug}.md`,
path: `${collection}/{yyyy}/{MM}/{dd}/{slug}.md`,
url: `${collection}/{yyyy}/{MM}/{dd}/{slug}`,
},
media: {
Expand Down
2 changes: 1 addition & 1 deletion packages/preset-eleventy/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe("preset-eleventy", async () => {

it("Gets publication post types", () => {
assert.deepEqual(eleventy.postTypes.get("article").post, {
path: "articles/{yyyy}-{MM}-{dd}-{slug}.md",
path: "articles/{yyyy}/{MM}/{dd}/{slug}.md",
url: "articles/{yyyy}/{MM}/{dd}/{slug}",
});
});
Expand Down
20 changes: 17 additions & 3 deletions packages/preset-eleventy/test/unit/post-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe("preset-eleventy/lib/post-types", () => {
assert.deepEqual(result.get("article"), {
name: "Journal post",
post: {
path: "articles/{yyyy}-{MM}-{dd}-{slug}.md",
path: "articles/{yyyy}/{MM}/{dd}/{slug}.md",
url: "articles/{yyyy}/{MM}/{dd}/{slug}",
},
media: {
Expand All @@ -26,7 +26,7 @@ describe("preset-eleventy/lib/post-types", () => {
assert.deepEqual(result.get("note"), {
name: "Micro post",
post: {
path: "notes/{yyyy}-{MM}-{dd}-{slug}.md",
path: "notes/{yyyy}/{MM}/{dd}/{slug}.md",
url: "notes/{yyyy}/{MM}/{dd}/{slug}",
},
media: {
Expand All @@ -36,12 +36,26 @@ describe("preset-eleventy/lib/post-types", () => {
assert.deepEqual(result.get("puppy"), {
name: "Puppy post",
post: {
path: "puppies/{yyyy}-{MM}-{dd}-{slug}.md",
path: "puppies/{yyyy}/{MM}/{dd}/{slug}.md",
url: "puppies/{yyyy}/{MM}/{dd}/{slug}",
},
media: {
path: "media/puppies/{yyyy}/{MM}/{dd}/{filename}",
},
});
});

it("Advertises a post URL Eleventy serves from the same path", () => {
const result = getPostTypes(postTypes);

for (const type of ["article", "note", "puppy"]) {
const { path, url } = result.get(type).post;

assert.equal(
path,
`${url}.md`,
`${type}: Eleventy derives a page's URL from its input path, so a post written to \`${path}\` is not served at \`${url}\``,
);
}
});
});
Loading