fix: Use refined dayjs parsing in date/time inputs - #8322
Merged
Conversation
distantnative
force-pushed
the
v6/fix/dayjs
branch
3 times, most recently
from
July 26, 2026 13:14
24eed60 to
9ca8e36
Compare
dayjs overhauldayjs overhaul
distantnative
commented
Jul 26, 2026
dayjs overhauldayjs parsing in date/time inputs
distantnative
force-pushed
the
v6/fix/dayjs
branch
3 times, most recently
from
July 26, 2026 13:33
8a7961b to
c2a9cf5
Compare
distantnative
changed the base branch from
v6/develop
to
v6/fix/dayjs-5-pattern-parse
July 26, 2026 13:33
distantnative
changed the base branch from
v6/fix/dayjs-5-pattern-parse
to
v6/fix/dayjs-5-locale
July 26, 2026 13:33
distantnative
force-pushed
the
v6/fix/dayjs
branch
from
July 26, 2026 14:16
c2a9cf5 to
48644cd
Compare
3 tasks
distantnative
force-pushed
the
v6/fix/dayjs
branch
2 times, most recently
from
July 26, 2026 22:13
72383fa to
981f08a
Compare
distantnative
commented
Jul 27, 2026
distantnative
force-pushed
the
v6/fix/dayjs
branch
from
July 27, 2026 14:12
981f08a to
7af7932
Compare
This was
linked to
issues
Jul 27, 2026
distantnative
force-pushed
the
v6/fix/dayjs
branch
2 times, most recently
from
August 3, 2026 16:13
a0a6389 to
fa6aeae
Compare
bastianallgeier
force-pushed
the
v6/fix/dayjs
branch
from
August 4, 2026 08:37
fa6aeae to
25d600d
Compare
distantnative
force-pushed
the
v6/fix/dayjs
branch
4 times, most recently
from
August 9, 2026 16:42
6aeac20 to
31c4e7e
Compare
distantnative
marked this pull request as ready for review
August 9, 2026 17:03
Member
|
It all works great and I love the placeholders. But there's a small tabbing bug, when I tab into the field with the custom strings … CleanShot.2026-08-15.at.12.20.20.mp4 |
distantnative
force-pushed
the
v6/fix/dayjs
branch
from
August 15, 2026 12:49
fd9fd9a to
5d7b195
Compare
Member
Author
|
@bastianallgeier improved/fixed that behavior (and related general tab key behavior) |
Member
Member
Author
|
Variable width here refers to the width of the month names. The display token is three characters wide but the actual display can vary in its length. I understand that it's confusing with not referring to the field width. |
Member
|
Ahh, that makes total sense. Maybe we should rename the label to "Variable month name width". That also works like a charm btw. I would say that this PR is ready from what I've tested. |
bastianallgeier
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Review
Timing: no rush
Description
Wrap-up of the
dayjswork: this connectsk-date-input/k-time-inputto the newdayjs.parse()and fixes the input behavior that the oldinterpret()call could never get right. The inputs now read what you typed against the field's owndisplaypattern.Changelog
✨ Enhancements
displayformat as placeholder, so the expected notation is visible before typing.https://feedback.getkirby.com/746
displayformat of date and time fields supports escaped literals, e.g.HH[h]mmorD [de] MMMM YYYY🐛 Bug fixes
displayformat instead of guessingDate/time field: unexpected results for arbitrary formats #6309
Date field value resets when pressing "save". #8024
[Panel] - Bug with date field when included in a structure field #6282
Date fields behave erratically when entering dates in M/D/YY format. #4211
Date field behaves weird when "display" MM/YYYY is used #6408
Date in structure field doesn't work when using the display tag to change the order of YYYY-MM-DD #7342
min/maxvalidation messages as times instead of datesDocs
displayoption (date, datetime, time fields)Anything dayjs formats works, and
text you want printed as it is goes in square brackets:
For review team
sandboxrepo