Fix Windows CI build on newer MSVC#8858
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Windows CMake build to work with newer MSVC behavior by scoping a coroutine-related compatibility preprocessor define to specific Flutter plugin targets, avoiding a broader language-mode change.
Changes:
- Adds a target-scoped compile definition to silence experimental coroutine deprecation warnings for select Windows plugins.
- Applies the define only when the plugin target exists, to keep configuration resilient across plugin set changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jay-418
approved these changes
Jun 12, 2026
jay-418
left a comment
jay-418
left a comment
Contributor
There was a problem hiding this comment.
Seems right for the failure we saw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MSVC experimental coroutine compatibility define to the Windows Flutter plugin targets that need it:
flutter_inappwebview_windows_pluginandflutter_local_notifications_windowsTested here: https://github.com/getlantern/lantern/actions/runs/27430885637