update readme to correct versions#8880
Closed
jigar-f wants to merge 2 commits into
Closed
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThe PR raises the minimum macOS version to 15.0 in the Xcode project build configurations (Runner and PacketTunnel targets), the CocoaPods Podfile platform floor, and the developer README. Simultaneously, all multilingual README download tables (root and profile directories) update Android minimum from 6+ to 7+ and macOS minimum from 10.15+ to 15.0+. ChangesmacOS Build Configuration Bump
Download Table Version Label Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
profile/README.zh.md (1)
37-46: 🗄️ Data Integrity & Integration | 🟠 MajorUpdate Android version in profile/README.zh.md from 6+ to 7+
Lines 37–46 in profile/README.zh.md still show "安卓 6+" but should be "安卓 7+" to align with:
- The Android 7+ minimum set in
android/app/build.gradle(minSdkVersion = 24)- All other profile README files (English, Russian, Farsi, Burmese, Arabic), which have all been correctly updated to Android 7+
Only the Chinese variant was not updated in this file.
Proposed fix
<tr> <th>安卓</th> <td> - <a href="https://gitlab.com/getlantern/lantern-binaries-mirror/-/raw/master/lantern-installer.apk">安卓 6&`#43`;</a> <br> - <a href="https://s3.amazonaws.com/lantern.io/releases/production/latest/lantern-installer.apk">安卓 6&`#43`;</a> <br> - <a href="https://github.com/getlantern/lantern/releases/latest/download/lantern-installer.apk">安卓 6&`#43`;</a> + <a href="https://gitlab.com/getlantern/lantern-binaries-mirror/-/raw/master/lantern-installer.apk">安卓 7&`#43`;</a> <br> + <a href="https://s3.amazonaws.com/lantern.io/releases/production/latest/lantern-installer.apk">安卓 7&`#43`;</a> <br> + <a href="https://github.com/getlantern/lantern/releases/latest/download/lantern-installer.apk">安卓 7&`#43`;</a> </td> <td> - <a href="https://play.google.com/store/apps/details?id=org.getlantern.lantern">安卓 6&`#43`;</a> + <a href="https://play.google.com/store/apps/details?id=org.getlantern.lantern">安卓 7&`#43`;</a> </td> <td> - <a href="https://s3.amazonaws.com/lantern.io/releases/beta/latest/lantern-installer-beta.apk">安卓 6&`#43`;</a> + <a href="https://s3.amazonaws.com/lantern.io/releases/beta/latest/lantern-installer-beta.apk">安卓 7&`#43`;</a> </td> </tr>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@profile/README.zh.md` around lines 37 - 46, Update all instances of "安卓 6+" to "安卓 7+" in the profile/README.zh.md file (lines 37-46). This aligns the Chinese README variant with the Android 7+ minimum version requirement set in android/app/build.gradle (minSdkVersion = 24) and matches the updates already completed in all other language variants of the profile README files. Replace each occurrence of the text "安卓 6+" with "安卓 7+" across all three download links and the Play Store link in the specified section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@profile/README.zh.md`:
- Around line 37-46: Update all instances of "安卓 6+" to "安卓 7+" in the
profile/README.zh.md file (lines 37-46). This aligns the Chinese README variant
with the Android 7+ minimum version requirement set in android/app/build.gradle
(minSdkVersion = 24) and matches the updates already completed in all other
language variants of the profile README files. Replace each occurrence of the
text "安卓 6+" with "安卓 7+" across all three download links and the Play Store
link in the specified section.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 196f4fc3-d750-4ed8-964a-c8aede7d582d
⛔ Files ignored due to path filters (1)
macos/Podfile.lockis excluded by!**/*.lock
📒 Files selected for processing (15)
README-dev.mdREADME.ar.mdREADME.fa.mdREADME.mdREADME.my.mdREADME.ru.mdREADME.zh.mdmacos/Podfilemacos/Runner.xcodeproj/project.pbxprojprofile/README.ar.mdprofile/README.fa.mdprofile/README.mdprofile/README.my.mdprofile/README.ru.mdprofile/README.zh.md
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the project’s stated and configured minimum supported platform versions—raising macOS deployment targets to 15.0 and updating Android minimum version messaging to 7.0—so documentation and build settings align.
Changes:
- Update macOS deployment target across Xcode project settings and CocoaPods (
15.0). - Update download-table labels across README translations and profile READMEs to reflect macOS
15.0+and Android7+. - Add a developer-facing note in
README-dev.mddescribing the new macOS minimum.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates Android/macOS minimum-version labels in download links. |
| README.ar.md | Updates Android/macOS minimum-version labels in download links. |
| README.fa.md | Updates Android/macOS minimum-version labels in download links. |
| README.my.md | Updates Android/macOS minimum-version labels in download links. |
| README.ru.md | Updates Android/macOS minimum-version labels in download links. |
| README.zh.md | Updates macOS minimum-version labels in download links (Android row still needs update). |
| README-dev.md | Adds developer note describing macOS 15.0 minimum support. |
| profile/README.md | Updates Android/macOS minimum-version labels in download links. |
| profile/README.ar.md | Updates Android/macOS minimum-version labels in download links. |
| profile/README.fa.md | Updates Android/macOS minimum-version labels in download links. |
| profile/README.my.md | Updates Android/macOS minimum-version labels in download links. |
| profile/README.ru.md | Updates Android/macOS minimum-version labels in download links. |
| profile/README.zh.md | Updates macOS minimum-version labels in download links (Android row still needs update). |
| macos/Runner.xcodeproj/project.pbxproj | Sets all MACOSX_DEPLOYMENT_TARGET values to 15.0. |
| macos/Podfile | Raises CocoaPods macOS platform floor to 15.0. |
| macos/Podfile.lock | Updates Podfile checksum to reflect Podfile change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the minimum supported versions for both macOS and Android platforms throughout the project. The minimum macOS deployment target is raised to 15.0 (Sequoia), and the minimum supported Android version is increased to 7.0. These changes are reflected in documentation, configuration files, and user-facing download links in multiple languages.
Platform Support Updates:
macos/Runner.xcodeproj/project.pbxproj) and CocoaPods configuration (macos/Podfile). [1] [2] [3] [4] [5] [6] [7]README-dev.md.Documentation and Download Link Updates:
README.md,README.ar.md,README.fa.md,README.my.md,README.ru.md,README.zh.md, andprofile/README.ar.md) to reflect the new minimum supported versions for both macOS (15.0) and Android (7.0) in download links and version labels. [1] [2] [3] [4] [5] [6] [7]These updates ensure that users and developers are informed about the new platform requirements and that the build configuration is consistent with the supported OS versions.
Summary by CodeRabbit