Test for JSON & CBOR encoding error handling#432
Merged
Conversation
Contributor
|
@bryceschober You refer to the try-except logic as a "hacky crap workaround". In my view, it is totally fine, not hacky at all. It is possible that jsoncons leaves us no other choice anyway. |
bryceschober
force-pushed
the
cbor-decode-exceptions
branch
from
1c9adca to
90a1f96
Compare
Contributor
Author
I have rebuilt this PR to reflect acceptance of the reality of the current universe. 😜 |
The current implementations using the `jsoncons` `decode_*()` functions always throw when there is a fundamental decoding error, as opposed to a mere type reflection mismatch.
bryceschober
force-pushed
the
cbor-decode-exceptions
branch
from
90a1f96 to
3eb2c6e
Compare
Contributor
|
@bryceschober merged. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a working illustration of the problem reported in #429.
The current implementation using
jsoncons::cbor::decode_cbor()always throws when there is a fundamental CBOR decoding error, as opposed to a mere structure reflection mismatch.