Update current location marker

[seadowg]

Closes #7106

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[seadowg]

I've marked this as "needs testing" as it's at a good point to have a play with and see if we can find bugs before I finish off. The blue dot should now show in all map views (without the "accuracy halo" in OSM/Mapbox as before), but the main thing to investigate is the maps and placement-map appearances as I had to do the most rework in that area of the code.

[dbemke]

The blue dot looks nice but I think users might be confused when there are other points on the map in geo widgets. There are many cases in which the blue dot is either confusing or covers some information.
In a geopoint with maps it covers the point - so you don't see your point at all.
In a goeshape/trace it looks like a point in a trace/shape- it's difficult to tell the difference if it's a point from a shape/trace or location marker (especially in Google Maps cause it's smaller - the screenshots).
In automatic location recording in geoshape/trace the location point covers the point which is being added... so it seems that the location is a point of the trace/shape which "waits" for the line to appear.
In the screenshot below try to find the location marker and the last point.

The most important part is to see points which are being added, so the dot would need to be transparent in the middle (something like a crosshair - pointing to a place but allowing added points to be visible).

[seadowg]

The blue dot looks nice but I think users might be confused when there are other points on the map in geo widgets.

Good point! It looks like the mock-up/Web Forms also change the single geopoint to a "pin" marker, so we should do this here as well. What does Web Forms do for the trace/shape vertices?

[WKobus]

Change for pin in single geopoint is already in on the PR version APK?

On WebForms vertices look simillar, here are the screenshots from geoshape/geotrace on WebForms

[seadowg]

Change for pin in single geopoint is already in on the PR version APK?

No I just mean that I think we should do that here as well.

On WebForms vertices look simillar, here are the screenshots from geoshape/geotrace on WebForms

OK so I can make these changes:

• Use "pin" icon for geopoint marker
• Make trace/shape vertices significantly smaller than the current location marker and use lighter color so it's obvious which is which

Does that sound like it will fix things @dbemke @WKobus?

[WKobus]

Changing location marker in geotrace/shape so it will be more different from vertices will fix it partially i think, there will still be a problem with it covering last entered point in automatic location recording for example.

[seadowg]

there will still be a problem with it covering last entered point in automatic location recording for example.

Is this not also a problem in Web Forms?