Send deviceid with formList requests#7181
Open
grzesiek2010 wants to merge 4 commits intogetodk:masterfrom
Open
Send deviceid with formList requests#7181grzesiek2010 wants to merge 4 commits intogetodk:masterfrom
grzesiek2010 wants to merge 4 commits intogetodk:masterfrom
Conversation
seadowg
requested changes
Apr 27, 2026
| private val settingsFactory: ProjectDependencyFactory<Settings>, | ||
| private val openRosaHttpInterface: OpenRosaHttpInterface | ||
| private val openRosaHttpInterface: OpenRosaHttpInterface, | ||
| private val propertyManager: PropertyManager |
Member
There was a problem hiding this comment.
PropertyManager implements IPropertyManager and its main job is to expose form metadata to JavaRosa - it's not really the right abstraction to be using here as we're not dealing with form metadata at all. Could we not just depend on InstallIDProvider here instead or even just installId (as a `String) itself given it should only be generated once?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7062
Why is this the best possible solution? Were any other approaches considered?
Not much to discuss here, as this is what we already did for one of our forks.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This change modifies the URL used to download forms, so we need to perform regression testing for form downloads, including forms with media files, entities, and form updates.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest