feat(#697): adds support to datetime question type#783
Conversation
🦋 Changeset detectedLatest commit: 7f2b282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@garethbowen Could you please take a look when you have some time? :) |
garethbowen
left a comment
There was a problem hiding this comment.
Great work. Tested briefly in Firefox and Chrome and looks great.
I hate to leave no comments so I spent a few minutes coming up with something to say... The only thing I can think of is there's quite a lot of duplication between InputTime, InputDate, and InputDateTime. If there was a bug/improvement made in one it's quite likely I would forget to update the other two to match so they may drift. What do you think about merging them into one file with conditions where needed?
I considered merging the components, but decided to extract the core logic into I still have two more features to build, so I’ll keep an eye on things. If the complexity starts to climb, we can look at extracting more shared logic from these inputs then. |
|
The GitHub Actions seemed to be out of service or extremely slow to start (+15min). The second commit is just testing whether the CI is working. |
Closes #697
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed