chore(#780): move tree-sitter-xpath into separate repo#784
Conversation
🦋 Changeset detectedLatest commit: def624e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
latin-panda
left a comment
latin-panda
left a comment
There was a problem hiding this comment.
So happy to see this extracted from the repo ✨
Can this be removed too: tsconfig.tools.json?
Approving now to unblock, since the suggestions below are minor.
There was a problem hiding this comment.
Is this comment still needed?
There was a problem hiding this comment.
I think it's not needed as it's caching the build output which is now just part of node_modules. Removed.
| "devDependencies": { | ||
| "@babel/core": "^7.28.5", | ||
| "@getodk/tree-sitter-xpath": "0.2.2", | ||
| "@getodk/tree-sitter-xpath": "^0.2.2", |
There was a problem hiding this comment.
Good call. Done.
There was a problem hiding this comment.
Is there any chance these 2 can be removed or moved somehow to the new tree-sitter repo? That way, we only include ODK's tree-sitter.
There was a problem hiding this comment.
Yes I think so. I'm cautious because of the web-tree-sitter peerdependency. Because WF has to list it as a dependency I don't think the resolutions from tree-sitter-xpath will be respected. I've removed them and nothing has changed in the lock file so I think we're good to go for now at least - if it breaks in the future we can add them back.
2 participants
Closes #780
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed