Skip to content

Adding muextensions - #1165

Open
pedrohdz wants to merge 1 commit into
getpelican:masterfrom
pedrohdz:muextensions
Open

pedrohdz wants to merge 1 commit into
getpelican:masterfrom
pedrohdz:muextensions

Conversation

@pedrohdz

Copy link
Copy Markdown
Contributor

@pedrohdz

Copy link
Copy Markdown
Contributor Author

I reviewed Contributing.rst and hoping that this makes it in even though it does not conform. :-/ The implementation of muextensions is more closely aligned with how plugin configuration is described in http://docs.getpelican.com/en/stable/plugins.html#how-to-use-plugins.

If this does not fly, how about adding an Honorable mention section to the bottom of the Readme.rst, and dropping the submodule?

I would love to get this out there as I think muextensions will be useful to others.

Many thanks!

@Lucas-C

Lucas-C commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

As mentioned recently in this PR, we are trying to move away from using git submodules.
We encourage new plugin authors to create repos under the pelican-plugins GitHub org, or to contribute to this monolothic repo.

There is already a PlantUML plugin in this repo but muextensions is very welcome ! It may be worth adding a short comparison table though.

@pedrohdz

pedrohdz commented Oct 14, 2019

Copy link
Copy Markdown
Contributor Author

@Lucas-C (@justinmayer ),
Given that muextensions includes support for Hovercraft! as well, adding it to the pelican-plugins mono-repo, or new organization does not seem to make sense, to me at least. :-) So I am going with option 2 ("creating a dedicated git repo and publishing it on Pypi").

More than anything I am looking for a way to share it and make it available for use by other Pelican users.

Maybe a page like Available Vagrant Plugins that lists related plugins?

As a side note muextensions adds support for ditaa as well, not just PlantUML. I might add QR codes in the future as well.

@Lucas-C

Lucas-C commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

Here are the detailed discussions on the subject:

You can for example use the Pypi classifier Framework::Pelican::Plugins and also add it on this page: https://github.com/getpelican/pelican/wiki/Externally-hosted-plugins-and-tools

@Lucas-C

Lucas-C commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

@pedrohdz What is you decision on this ? Do you plan to publish your plugins on Pypi ?
If you still wish to contribute here, it may be best to submit the code directly, not as a git sub-module but in a dedicated directory.

@justinmayer

Copy link
Copy Markdown
Member

Hey @pedrohdz! Since muextensions has support for projects besides Pelican, I can see your perspective. Another idea that occurred to me was moving the Pelican-specific portion into its own pelican-plugins/muextensions repository. That way, the plugin could list muextensions as a dependency, which would be installed automatically when running pip install pelican-muextensions. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants