Conversation
Author
|
I also have a patch to translate the values from But I think that this patch is still valid for people who don't want to use gettext |
|
@adiroiban Mind filing the same against my fork at https://github.com/georgkrause/i18n_subsites ? |
rschiang
added a commit
to rschiang/pelican-plugins
that referenced
this pull request
Aug 9, 2022
[i18n_subsites] Allow merging the base settings with the translations settings.
rschiang
added a commit
to rschiang/pelican-i18n-subsites
that referenced
this pull request
Aug 9, 2022
…ict-merge [i18n_subsites] Allow merging the base settings with the translations settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help organize the translations any text from pelicanconf.py that is presented on the site is put in a common dictionary
The idea is that if you add a new value in the default site and that site is not translated, it will be present in the translated site using the default language....similar to gettext.
Instead of using a simple copy with overwriting of root dict keys I went with a simple dict merge code.
I have simplified the tests.
to run the tests
An example