execute button shortcut: command+enter instead of mod+enter#7593
Draft
yoshiokatsuneo wants to merge 2 commits intogetredash:masterfrom
Draft
execute button shortcut: command+enter instead of mod+enter#7593yoshiokatsuneo wants to merge 2 commits intogetredash:masterfrom
yoshiokatsuneo wants to merge 2 commits intogetredash:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
On Windows, when ctrl-enter shortcut is used to execute the query, API is called twice. This happens because ctrl-enter handler is registered twice on Windows where mod+enter is mapped to ctrl+enter that is already exists.
This PR fixed the issue by using command+enter instead of mod+enter.
Related PR: #7592
Description
How is this tested?
I tested on Mac that the query was run using command-enter, ctrl-enter, alt-enter, shift-enter.
(I haven't tested on Windows.)