Open
Conversation
This uses boto3 and PartiQL query syntax instead of the old unmaintained dynamodb package. DynamoDB support was never removed from the README, so no documentation updates are needed there.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Thank you ! |
Contributor
|
And, can you fix the styling test error by running black? |
arikfr
reviewed
Mar 11, 2026
Member
arikfr
left a comment
arikfr
left a comment
There was a problem hiding this comment.
- Note that you need to apply black formatting.
- You need to add a logo in
client/app/assets/images/db-logos.
kimsehwan96
reviewed
Mar 13, 2026
| "aws_secret_key": {"type": "string", "title": "AWS Secret Key"}, | ||
| "endpoint_url": {"type": "string", "title": "Endpoint URL (optional)"}, | ||
| }, | ||
| "required": ["region", "aws_access_key", "aws_secret_key"], |
Contributor
There was a problem hiding this comment.
I think aws_access_key and aws_secret_key should not be set as required. Because If some environment like AWS EKS, the redash pods might use IRSA as the authentication source, then the aws_access_key and aws_secret_key doesn't need like Athena query runner. (Athena query runner doesn't set the keys as required)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Add back support for DynamoDB. This uses boto3 and PartiQL query syntax instead of the old unmaintained dynamodb package.DynamoDB support was never removed from the README, so no documentation updates are needed there.
How is this tested?
Built and deployed an image that was successfully able to create a DynamoDB data source and run a DynamoDB query.