Conversation
5 tasks
Upgrade urllib3 to 2.7.0 with matching AWS SDK bumps, and restore SSRF protection via champion in one PR so ENFORCE_PRIVATE_ADDRESS_BLOCK is never left dead (supersedes getredash#7745). - Remove unmaintained advocate (blocks urllib3 2.x) - urllib3 1.26.19 → 2.7.0; boto3/botocore → 1.43.7 - Add optional uv dependency group `ssrf` pinned to champion git rev - Default ENFORCE_PRIVATE_ADDRESS_BLOCK to false (opt-in + champion) - Wire requests_or_champion through HTTP/CSV/Excel query runners Co-authored-by: Cursor <cursoragent@cursor.com>
wtfiwtz
force-pushed
the
security/champion-ssrf
branch
from
August 4, 2026 03:38
071092c to
bf23454
Compare
Contributor
Author
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace deprecated
advocatewithchampionand upgrade urllib3 to 2.x in one PR, soENFORCE_PRIVATE_ADDRESS_BLOCKis never left without an SSRF implementation.Rebased onto current
masterafter #7755 (Poetry → uv) and #7768 (Authlib stack). Supersedes #7745 (closed).Dependency changes
advocate==1.0.0urllib3: 1.26.19 → 2.7.0boto3/botocore: 1.28.8 / 1.31.8 → 1.43.7ssrfwithchampionpinned to git rev74cf301Code / settings
requests_or_advocate→requests_or_championENFORCE_PRIVATE_ADDRESS_BLOCKdefault:true→false(opt-in; requires champion install)Enable SSRF protection
REDASH_ENFORCE_PRIVATE_IP_BLOCK=trueuv sync --group ssrf(or addssrfto Dockerfileinstall_groups)What type of PR is this?
How is this tested?
Related