Fix 500 when creating text widgets without visualization_id - #7796
Open
amirshahzadhashmi7145 wants to merge 1 commit into
Open
amirshahzadhashmi7145 wants to merge 1 commit into
amirshahzadhashmi7145 wants to merge 1 commit into
Conversation
Greptile SummaryThe PR prevents text-widget creation from failing when
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| redash/handlers/widgets.py | Safely treats an omitted visualization identifier like the already-supported explicit-null case. |
| tests/handlers/test_widgets.py | Adds focused regression coverage for text-widget creation without visualization_id. |
Reviews (3): Last reviewed commit: "Fix 500 when creating a text widget with..." | Re-trigger Greptile
amirshahzadhashmi7145
force-pushed
the
fix/7793-text-widget-missing-visualization-id
branch
from
September 3, 2026 12:33
a221ffa to
365d5ef
Compare
POST /api/widgets treated a missing visualization_id as a KeyError instead of a text widget. Co-authored-by: Cursor <cursoragent@cursor.com>
amirshahzadhashmi7145
force-pushed
the
fix/7793-text-widget-missing-visualization-id
branch
from
September 6, 2026 20:38
365d5ef to
7bd1f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/widgetsno longer 500s whenvisualization_idis omitted (text widgets).Test plan
POST /api/widgetswith{dashboard_id, width, text}(novisualization_id) returns 200"visualization_id": nullstill returns 200