Keep query-based dropdown empty after clicking clear

[amirshahzadhashmi7145]

Summary

• Query-based dropdowns no longer snap back to the first option after clicking X.
• Fixes Error when using the "X" button in the Query-Based Dropdown List. #7361

Test plan

• Query-based dropdown: select a value, click X, field stays empty
• Selecting a value still works
• After options reload, a valid existing value is kept

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="client/app/components/QueryBasedParameterInput.jsx">

<violation number="1" location="client/app/components/QueryBasedParameterInput.jsx:56">
P2: When a dropdown query contains an option with an empty-string value, this branch clears it before the option lookup, so the option cannot be selected or restored. Treat only nullish values as the clear state, since empty strings are supported option values.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When a dropdown query contains an option with an empty-string value, this branch clears it before the option lookup, so the option cannot be selected or restored. Treat only nullish values as the clear state, since empty strings are supported option values.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At client/app/components/QueryBasedParameterInput.jsx, line 56:

<comment>When a dropdown query contains an option with an empty-string value, this branch clears it before the option lookup, so the option cannot be selected or restored. Treat only nullish values as the clear state, since empty strings are supported option values.</comment>

<file context>
@@ -53,10 +53,14 @@ export default class QueryBasedParameterInput extends React.Component {
-    value = found ? value : get(first(options), "value");
-    this.setState({ value });
-    return value;
+    if (value == null || value === "") {
+      this.setState({ value: undefined });
+      return null;
</file context>

Suggested change

	if (value == null || value === "") {
	if (value == null) {

[greptile-apps]

Greptile Summary

The PR preserves an explicitly cleared query-based dropdown instead of automatically selecting its first option again.

• Adds an early return for null, undefined, and empty-string values.
• Retains the existing validation and fallback behavior for non-empty selections.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
client/app/components/QueryBasedParameterInput.jsx	Adds empty-value handling before the existing option validation and first-option fallback; no eligible follow-up defect was identified.

_{Reviews (3): Last reviewed commit: "Keep query-based dropdown empty after cl..." | Re-trigger Greptile}

[yoshiokatsuneo]

I think it is easier to review if the diff for PR is minimum.

[amirshahzadhashmi7145]

Thanks for the feedback — I've reduced the diff to the minimum needed for the fix: a 4-line early return in `setValue` when the value is cleared, with no other logic changes.

Rebased onto latest `master` as well.