feat: Add launchpad taskworker container#4267
Draft
NicoHinderling wants to merge 2 commits intomasterfrom
Draft
Conversation
Add a launchpad-taskworker service that shares the existing taskbroker
infrastructure with the sentry taskworker. Activations are separated by
the `application` value ("launchpad" vs "sentry") so workers only fetch
their own tasks.
Changelog Preview📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
launchpad-taskworkerservice to the self-hosted docker-compose setup. This allows Launchpad (preprod artifact processing) to run alongside Sentry in self-hosted deployments.The launchpad taskworker shares the existing taskbroker and Kafka infrastructure with the sentry taskworker. Because each application registers with a different
applicationvalue ("launchpad"vs"sentry"), workers only fetch tasks from their own application — no cross-contamination.Changes:
.env: AddLAUNCHPAD_IMAGEandLAUNCHPAD_TASKWORKER_CONCURRENCYvariablesdocker-compose.yml: Addlaunchpad-taskworkerservice with taskbroker, kafka, and web dependenciesBefore merging, these need to be resolved:
LAUNCHPAD_IMAGE— currently set tonightly; should be pinned to a release tagLAUNCHPAD_RPC_SHARED_SECRET— left empty; needs the shared secret for authenticating API calls back to sentryOBJECTSTORE_URL— not included (app icon processing is skipped without it); may needhttp://seaweedfs:8333if requiredTesting
Pull the launchpad image:
Start the new service:
Verify the container starts and connects to the taskbroker:
Expected: container starts, connects to
taskbroker:50051, and waits for tasks.Verify health check passes:
Should show
healthystatus after the start period.Ref: the sentry taskworker definition at L771-L775 was the template for this, per Mark Story's guidance.