Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7778 +/- ##
=============================================
+ Coverage 85.135% 85.392% +0.256%
=============================================
Files 487 487
Lines 29183 29183
Branches 12612 12621 +9
=============================================
+ Hits 24845 24920 +75
+ Misses 4286 4212 -74
+ Partials 52 51 -1 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8d9e501 | 1233.04 ms | 1260.40 ms | 27.35 ms |
| d0b4402 | 1218.62 ms | 1241.80 ms | 23.18 ms |
| e06cf5f | 1222.96 ms | 1254.66 ms | 31.70 ms |
| 09a80f2 | 1214.78 ms | 1237.85 ms | 23.07 ms |
| 17fe3fd | 1224.77 ms | 1259.00 ms | 34.23 ms |
| dbfeb41 | 1215.17 ms | 1237.41 ms | 22.23 ms |
| 0e4a9dc | 1222.92 ms | 1255.78 ms | 32.86 ms |
| b882255 | 1216.49 ms | 1253.66 ms | 37.17 ms |
| 4883c74 | 1224.80 ms | 1258.65 ms | 33.85 ms |
| 5fff6ba | 1206.13 ms | 1232.49 ms | 26.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8d9e501 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| d0b4402 | 24.14 KiB | 1.11 MiB | 1.08 MiB |
| e06cf5f | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| 09a80f2 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 17fe3fd | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| dbfeb41 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 0e4a9dc | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| b882255 | 24.14 KiB | 1.12 MiB | 1.09 MiB |
| 4883c74 | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| 5fff6ba | 24.14 KiB | 1.13 MiB | 1.10 MiB |
Package@swift-6.2.swift
Outdated
| var targets: [Target] = [ | ||
| .binaryTarget( | ||
| name: "Sentry", | ||
| url: "https://github.com/getsentry/sentry-cocoa/releases/download/9.9.0/Sentry.xcframework.zip", |
There was a problem hiding this comment.
Bug: The new Package@swift-6.2.swift file is missing from the hardcoded list in the VersionBump script, which will prevent its binary target URLs from being updated during releases.
Severity: HIGH
Suggested Fix
Add Package@swift-6.2.swift to the files array in Utils/VersionBump/main.swift. Consider using a glob pattern to automatically discover Package@swift-*.swift files to prevent this issue in the future.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: Package@swift-6.2.swift#L26
Potential issue: The `VersionBump` utility, used during releases, relies on a hardcoded
list of files to update version numbers. The newly added `Package@swift-6.2.swift` is
not in this list. Consequently, when a new version is released, the binary target URLs
within this file will not be updated and will continue to point to the old `9.9.0`
binaries. While the checksum update script correctly discovers the file, it cannot fix
the stale URLs. This will cause Swift 6.2+ users to silently receive an outdated SDK
version, regardless of the version they specify in their package dependencies.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ce93130. Configure here.

📜 Description
Add a newer
Package@swift-6.2.swift, so newer SPM tools use it instead and allow using unsafe flags.💡 Motivation and Context
When using plain SPM, seems like using unsafe flags is disabled when swift tools is lower than 6.1
Fixes: #7738
💚 How did you test it?
Tested it with a sample project and using releases on a fork
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.