fix(replay): Scope clipOut masking to active clip bounds#7780
Merged
Conversation
Ensure clipOut regions are applied only within the current clipBegin/clipEnd scope, so holes don’t leak outside parent clipped areas.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7780 +/- ##
=============================================
+ Coverage 85.455% 85.476% +0.020%
=============================================
Files 487 487
Lines 29159 29166 +7
Branches 12622 12614 -8
=============================================
+ Hits 24918 24930 +12
+ Misses 4191 4185 -6
- Partials 50 51 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sentry Build Distribution
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e92ab66 | 1228.86 ms | 1258.43 ms | 29.57 ms |
| 98a16ef | 1227.45 ms | 1258.19 ms | 30.74 ms |
| 37ebda0 | 1201.62 ms | 1223.76 ms | 22.13 ms |
| f567e36 | 1215.04 ms | 1245.10 ms | 30.06 ms |
| bbee1ba | 1197.79 ms | 1215.42 ms | 17.63 ms |
| a180235 | 1222.87 ms | 1255.10 ms | 32.23 ms |
| c424b6a | 1220.38 ms | 1248.18 ms | 27.80 ms |
| 5edcfc8 | 1228.14 ms | 1264.15 ms | 36.00 ms |
| d6d7fcf | 1192.78 ms | 1215.60 ms | 22.83 ms |
| d68691e | 1221.48 ms | 1248.13 ms | 26.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e92ab66 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 98a16ef | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 37ebda0 | 24.14 KiB | 1.10 MiB | 1.07 MiB |
| f567e36 | 24.14 KiB | 1.13 MiB | 1.10 MiB |
| bbee1ba | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| a180235 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| c424b6a | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 5edcfc8 | 24.14 KiB | 1.12 MiB | 1.09 MiB |
| d6d7fcf | 24.14 KiB | 1.12 MiB | 1.10 MiB |
| d68691e | 24.14 KiB | 1.12 MiB | 1.09 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Ensure clipOut regions are applied only within the current clipBegin/clipEnd scope, so holes don’t leak outside parent clipped areas.
💡 Motivation and Context
Closes #5305
💚 How did you test it?
Added unit + regression tests.
Tested locally with RN app. Could re-produce the issue before, but not after. Here is the correct Replay
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.