Conversation
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
==========================================
- Coverage 88.97% 88.62% -0.35%
==========================================
Files 263 263
Lines 8931 8766 -165
==========================================
- Hits 7946 7769 -177
- Misses 985 997 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68677de | 364.41 ms | 415.61 ms | 51.20 ms |
| 8e133ad | 360.08 ms | 402.82 ms | 42.74 ms |
| 9a5040f | 490.15 ms | 563.98 ms | 73.83 ms |
| 6aab859 | 306.27 ms | 377.92 ms | 71.65 ms |
| 752e1cb | 472.85 ms | 511.60 ms | 38.76 ms |
| 2e1e4ae | 413.34 ms | 509.24 ms | 95.90 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 84bc635 | 395.57 ms | 464.23 ms | 68.66 ms |
| 134c9f8 | 301.40 ms | 352.65 ms | 51.26 ms |
| c328ffc | 394.35 ms | 480.94 ms | 86.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 8e133ad | 6.06 MiB | 7.03 MiB | 990.29 KiB |
| 9a5040f | 6.46 MiB | 7.48 MiB | 1.01 MiB |
| 6aab859 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
| 752e1cb | 6.49 MiB | 7.57 MiB | 1.08 MiB |
| 2e1e4ae | 6.35 MiB | 7.42 MiB | 1.06 MiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 84bc635 | 6.34 MiB | 7.28 MiB | 968.41 KiB |
| 134c9f8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| c328ffc | 6.35 MiB | 7.42 MiB | 1.07 MiB |
Previous results on branch: v9
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98d6f2d | 500.02 ms | 504.48 ms | 4.46 ms |
| 7f8043c | 455.82 ms | 534.94 ms | 79.12 ms |
| dd80448 | 481.70 ms | 549.76 ms | 68.06 ms |
| bb29ef9 | 433.86 ms | 506.36 ms | 72.50 ms |
| c42f951 | 456.10 ms | 578.76 ms | 122.66 ms |
| a685eaf | 420.25 ms | 502.04 ms | 81.79 ms |
| 342e82b | 431.96 ms | 532.56 ms | 100.60 ms |
| 1fa8baa | 451.78 ms | 533.84 ms | 82.06 ms |
| 3e1c2c9 | 468.75 ms | 522.04 ms | 53.29 ms |
| 7c468df | 427.53 ms | 518.43 ms | 90.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 98d6f2d | 6.46 MiB | 7.48 MiB | 1.03 MiB |
| 7f8043c | 6.44 MiB | 7.56 MiB | 1.12 MiB |
| dd80448 | 6.44 MiB | 7.56 MiB | 1.11 MiB |
| bb29ef9 | 6.46 MiB | 7.61 MiB | 1.15 MiB |
| c42f951 | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| a685eaf | 6.46 MiB | 7.61 MiB | 1.15 MiB |
| 342e82b | 6.44 MiB | 7.56 MiB | 1.11 MiB |
| 1fa8baa | 6.46 MiB | 7.61 MiB | 1.15 MiB |
| 3e1c2c9 | 6.46 MiB | 7.48 MiB | 1.03 MiB |
| 7c468df | 6.46 MiB | 7.61 MiB | 1.15 MiB |
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcdb5 | 1230.87 ms | 1244.94 ms | 14.06 ms |
| 4d046e0 | 1243.08 ms | 1255.98 ms | 12.90 ms |
| 0ceb89c | 1252.02 ms | 1271.78 ms | 19.75 ms |
| f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
| c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
| dd25e43 | 1261.59 ms | 1275.81 ms | 14.22 ms |
| 2e93bab | 1237.08 ms | 1258.41 ms | 21.33 ms |
| ee0ca56 | 1236.44 ms | 1258.89 ms | 22.45 ms |
| bd75526 | 1252.62 ms | 1287.00 ms | 34.38 ms |
| 178baee | 1230.61 ms | 1249.94 ms | 19.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abfcdb5 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 4d046e0 | 8.42 MiB | 9.83 MiB | 1.40 MiB |
| 0ceb89c | 8.15 MiB | 9.12 MiB | 989.78 KiB |
| f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| dd25e43 | 8.42 MiB | 9.87 MiB | 1.44 MiB |
| 2e93bab | 8.38 MiB | 9.73 MiB | 1.36 MiB |
| ee0ca56 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
| bd75526 | 8.38 MiB | 9.76 MiB | 1.39 MiB |
| 178baee | 8.34 MiB | 9.67 MiB | 1.33 MiB |
Previous results on branch: v9
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce53819 | 1257.65 ms | 1270.98 ms | 13.33 ms |
| 98d6f2d | 1240.77 ms | 1255.84 ms | 15.07 ms |
| 0f8bd48 | 1252.27 ms | 1273.90 ms | 21.63 ms |
| 7f8043c | 1252.16 ms | 1265.42 ms | 13.25 ms |
| a685eaf | 1246.61 ms | 1275.92 ms | 29.30 ms |
| 1fa8baa | 1246.75 ms | 1266.64 ms | 19.89 ms |
| 7c468df | 1256.13 ms | 1273.92 ms | 17.79 ms |
| 8043355 | 1229.21 ms | 1245.43 ms | 16.22 ms |
| c42f951 | 1244.28 ms | 1261.11 ms | 16.83 ms |
| bb29ef9 | 1247.35 ms | 1264.12 ms | 16.78 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ce53819 | 8.42 MiB | 9.91 MiB | 1.48 MiB |
| 98d6f2d | 8.42 MiB | 9.91 MiB | 1.48 MiB |
| 0f8bd48 | 8.42 MiB | 9.97 MiB | 1.55 MiB |
| 7f8043c | 8.43 MiB | 9.97 MiB | 1.54 MiB |
| a685eaf | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 1fa8baa | 8.42 MiB | 9.97 MiB | 1.54 MiB |
| 7c468df | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 8043355 | 8.42 MiB | 9.91 MiB | 1.48 MiB |
| c42f951 | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| bb29ef9 | 8.42 MiB | 9.97 MiB | 1.54 MiB |
* chore: update flutter/scripts/update-android.sh to 8.1.0 * Update CHANGELOG.md --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Ivan Dlugos <6349682+vaind@users.noreply.github.com>
* remove manual TTID * update CHANGELOG * remove assertion * use SentryTraceOrigins.autoUiTimeToDisplay as origin
* remove * remove rest of user segment * update CHANGELOG * fix analyze
* remove * remove unused code * update CHANGELOG
* remove dartLogger and make noOpLogger internal * update comment * update CHANGELOG * remove ignores
* add JNI and use in replay.onScreenshotRecorded * exlude bindings from coverage * use jni bitmap * move all native to android_replay_recorder * android screenshot isolate * cleanup * use persistent isolate * update replay native tests * update high-risk-code list * remove print() * remove package:file dependency * JNI benchmark * ktlint format * fixup ci * fixup * fix web tests * dart format * try to fix ci * try to fix ci * chore: exclude binding from coverage * comments * chore: changelog * move uint8list creation to separate isolate * Update CHANGELOG.md Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
* remove dart:html usage and used package:web instead * update CHANGELOG and remove publish validation * remove publish validation from ci * update web_example dep * update * remove more conditionals
* remove enableTracing * remove ignore * update CHANGELOG * add test * format * update test
* remove old user feedback api * update * update changelog * fix mock * update * update
…ueryExecutor` (#2679) * temp * update * update * update docs * update * Update sentry.dart * update CHANGELOG * update * fist tests * formatting * fix analyze * fix analyze * formatting and change integration name from to * improve ensureOpen instrumentation * fix hub not using hubadapter as fallback * update parent span * use stack to handle parent span * formatting * formatting * fix analyze * add disabled tracing test * unused code * temp * update * add test * remove spotlight * cleanup test file * add select query test: * removing stack in finally block
# Conflicts: # drift/lib/src/sentry_query_executor.dart # drift/lib/src/sentry_span_helper.dart # drift/test/sentry_database_test.dart # flutter/example/lib/main.dart
* fix tests * re-enable test
* Remove workaround for Platform.executable * add // ignore: deprecated_member_use
# Conflicts: # flutter/lib/src/renderer/html_renderer.dart # flutter/test/mocks.mocks.dart
* update Android dependency to 7.22.0 (#2705) * fix: navigation breadcrumb with missing to crashes native (#2720) * release: 8.13.1 * update changelog * fix(web): use `if (dart.library.html)` instead of `if (dart.html)` (#2736) * fix * regenerate mocks * update CHANGELOG * update test * update * fix test * release: 8.13.2 * Use global ruby for `pod install` in min version test (#2783) * chore(deps): update Cocoa SDK to v8.46.0 (#2772) * chore: update flutter/scripts/update-cocoa.sh to 8.46.0 * Update CHANGELOG.md --------- Co-authored-by: GitHub <noreply@github.com> Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * Bind root screen transaction to scope (#2756) * chore(deps): update Android SDK to v7.22.1 (#2785) * update android dep * update changelog * update CHANGELOG * release: 8.13.3 * update CHANGELOG * Prepare `8.14.0` changelog (#2787) * update CHANGELOG * update * Update CHANGELOG.md * Update CHANGELOG.md * release: 8.14.0 --------- Co-authored-by: getsentry-bot <bot@sentry.io> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub <noreply@github.com> Co-authored-by: getsentry-bot <bot@getsentry.com>
buenaflor
requested review from
buenaflor,
krystofwoldrich and
stefanosiano
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be merged (without squashing) back to main when ready and we want to do a release.
#skip-changelog