Skip to content

Test wether isolate completes when sentry is closed#2822

Merged
denrase merged 4 commits intomainfrom
enha/add-isolate-close-test
Apr 2, 2025
Merged

Test wether isolate completes when sentry is closed#2822
denrase merged 4 commits intomainfrom
enha/add-isolate-close-test

Conversation

@denrase
Copy link
Copy Markdown
Collaborator

@denrase denrase commented Mar 26, 2025

#skip-changelog

📜 Description

Add a test to check if an isolate completes when sentry is closed.

💡 Motivation and Context

Relates to #2625

It turns out, we need to close sentry to complete an isolate. We should document this behaviour somewhere.

💚 How did you test it?

Added test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (3fcbad3) to head (1d58665).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2822      +/-   ##
==========================================
+ Coverage   88.53%   88.59%   +0.06%     
==========================================
  Files         265      265              
  Lines        8867     8867              
==========================================
+ Hits         7850     7856       +6     
+ Misses       1017     1011       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denrase denrase marked this pull request as ready for review March 26, 2025 15:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1260.23 ms 1271.92 ms 11.69 ms
Size 8.43 MiB 9.99 MiB 1.56 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d089990 1206.19 ms 1233.08 ms 26.89 ms
6aab859 1245.14 ms 1247.59 ms 2.45 ms
dd5521e 1254.28 ms 1263.37 ms 9.09 ms
07cd9e8 1237.04 ms 1257.50 ms 20.46 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
a7acb24 1296.71 ms 1317.69 ms 20.98 ms
e4d5aa8 1224.15 ms 1245.72 ms 21.57 ms
a61674e 1275.51 ms 1290.81 ms 15.30 ms
6034b0a 1244.89 ms 1270.22 ms 25.33 ms
73d70bf 1249.08 ms 1268.41 ms 19.33 ms

App size

Revision Plain With Sentry Diff
d089990 8.33 MiB 9.40 MiB 1.07 MiB
6aab859 8.29 MiB 9.36 MiB 1.07 MiB
dd5521e 8.43 MiB 9.97 MiB 1.54 MiB
07cd9e8 8.38 MiB 9.77 MiB 1.40 MiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
a7acb24 8.16 MiB 9.17 MiB 1.01 MiB
e4d5aa8 8.33 MiB 9.62 MiB 1.29 MiB
a61674e 8.10 MiB 9.16 MiB 1.07 MiB
6034b0a 8.33 MiB 9.40 MiB 1.07 MiB
73d70bf 8.38 MiB 9.70 MiB 1.33 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 474.02 ms 492.96 ms 18.94 ms
Size 6.44 MiB 7.44 MiB 1015.90 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
03e4c9b 410.34 ms 493.20 ms 82.86 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
6fedcab 388.26 ms 487.42 ms 99.16 ms
803f3a9 424.66 ms 505.24 ms 80.58 ms
ffae3e3 360.67 ms 466.24 ms 105.57 ms
bf4aed7 311.24 ms 365.66 ms 54.42 ms
ddc97ad 331.45 ms 384.06 ms 52.61 ms
d53c6fa 282.83 ms 344.00 ms 61.17 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
547db82 453.40 ms 482.88 ms 29.48 ms

App size

Revision Plain With Sentry Diff
03e4c9b 6.35 MiB 7.42 MiB 1.07 MiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
6fedcab 6.33 MiB 7.30 MiB 987.83 KiB
803f3a9 6.46 MiB 7.48 MiB 1.02 MiB
ffae3e3 6.26 MiB 7.20 MiB 958.78 KiB
bf4aed7 6.06 MiB 7.03 MiB 997.04 KiB
ddc97ad 6.16 MiB 7.14 MiB 1003.75 KiB
d53c6fa 6.16 MiB 7.14 MiB 1011.18 KiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB

Previous results on branch: enha/add-isolate-close-test

Startup times

Revision Plain With Sentry Diff
5770e36 455.80 ms 532.40 ms 76.60 ms

App size

Revision Plain With Sentry Diff
5770e36 6.44 MiB 7.57 MiB 1.12 MiB

@denrase denrase merged commit 67277fc into main Apr 2, 2025
153 of 154 checks passed
@denrase denrase deleted the enha/add-isolate-close-test branch April 2, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants