Skip to content

v9: Set log level to warning by default #2836

Merged
buenaflor merged 7 commits intomainfrom
v9-log-level
Apr 3, 2025
Merged

v9: Set log level to warning by default #2836
buenaflor merged 7 commits intomainfrom
v9-log-level

Conversation

@buenaflor
Copy link
Copy Markdown
Contributor

📜 Description

Update logging min level

💡 Motivation and Context

Closes #2816

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (df9bb61) to head (2d372d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   88.59%   88.58%   -0.02%     
==========================================
  Files         265      265              
  Lines        8867     8871       +4     
==========================================
+ Hits         7856     7858       +2     
- Misses       1011     1013       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 478.63 ms 545.10 ms 66.47 ms
Size 6.44 MiB 7.43 MiB 1014.58 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
03e4c9b 410.34 ms 493.20 ms 82.86 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
6fedcab 388.26 ms 487.42 ms 99.16 ms
803f3a9 424.66 ms 505.24 ms 80.58 ms
ffae3e3 360.67 ms 466.24 ms 105.57 ms
bf4aed7 311.24 ms 365.66 ms 54.42 ms
ddc97ad 331.45 ms 384.06 ms 52.61 ms
d53c6fa 282.83 ms 344.00 ms 61.17 ms
f922f8f 332.31 ms 374.67 ms 42.37 ms
547db82 453.40 ms 482.88 ms 29.48 ms

App size

Revision Plain With Sentry Diff
03e4c9b 6.35 MiB 7.42 MiB 1.07 MiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
6fedcab 6.33 MiB 7.30 MiB 987.83 KiB
803f3a9 6.46 MiB 7.48 MiB 1.02 MiB
ffae3e3 6.26 MiB 7.20 MiB 958.78 KiB
bf4aed7 6.06 MiB 7.03 MiB 997.04 KiB
ddc97ad 6.16 MiB 7.14 MiB 1003.75 KiB
d53c6fa 6.16 MiB 7.14 MiB 1011.18 KiB
f922f8f 5.94 MiB 6.95 MiB 1.01 MiB
547db82 6.49 MiB 7.56 MiB 1.07 MiB

@buenaflor buenaflor marked this pull request as draft April 1, 2025 13:00
@buenaflor buenaflor marked this pull request as ready for review April 2, 2025 11:18
@buenaflor buenaflor merged commit 654242a into main Apr 3, 2025
37 of 38 checks passed
@buenaflor buenaflor deleted the v9-log-level branch April 3, 2025 10:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Set log level to `warning` by default ([#2836](https://github.com/getsentry/sentry-dart/pull/2836))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2d372d3

buenaflor added a commit that referenced this pull request Apr 11, 2025
* update

* update test

* update init native sdk test

* Update CHANGELOG

* Add additional test
buenaflor added a commit that referenced this pull request Apr 15, 2025
* v9: Set log level to `warning` by default  (#2836)

* update

* update test

* update init native sdk test

* Update CHANGELOG

* Add additional test

* Update CHANGELOG

* Update CHANGELOG

* Update

* Update

* Fix test

* Fix test

* Fix analyze

* Remove prod scheme

* Update mocks

* Update mocks
buenaflor added a commit that referenced this pull request Apr 24, 2025
* Fix: Improve platform memory collection on windows/linux (#2798)

* deps: bump Android from `7.22.1` to `7.22.4` (#2810)

* update android deps

* Update CHANGELOG.md

* Fix adding runtime to contexts (#2813)

* Fix CHANGELOG formatting

* release: 8.14.1

* fix: `options.diagnosticLevel` not affecting logs (#2856)

* v9: Set log level to `warning` by default  (#2836)

* update

* update test

* update init native sdk test

* Update CHANGELOG

* Add additional test

* Update CHANGELOG

* Update CHANGELOG

* Update

* Update

* Fix test

* Fix test

* Fix analyze

* Remove prod scheme

* Update mocks

* Update mocks

* Improve performance of frames tracking (#2854)

* Improve performance

* Update tests

* Improve performance

* Formatting

* Separate function

* Remove separate function

* Update

* Improve frames tracking performance

* update naming

* Update

* update

* update

* Edge case

* Update mocks

* formatting

* Improvements

* Analyze

* Update mocks

* Update mocks

* Clean up `getSpan()` log (#2865)

* Remove unnecessary log and document the behaviour

* Typo

* Typo

* Add CHANGELOG entry

* release: 8.14.2

* Update

* Update

---------

Co-authored-by: Denis Andrašec <denrase@gmail.com>
Co-authored-by: getsentry-bot <bot@sentry.io>
Co-authored-by: getsentry-bot <bot@getsentry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v9]: Set default log level to SentryLevel.warning if debug is enabled

2 participants