fix: span ids not re-generating for headers created from scope#3051
Merged
fix: span ids not re-generating for headers created from scope#3051
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
+ Coverage 87.98% 88.05% +0.06%
==========================================
Files 287 286 -1
Lines 9533 9541 +8
==========================================
+ Hits 8388 8401 +13
+ Misses 1145 1140 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denrase
approved these changes
Jul 8, 2025
Collaborator
denrase
left a comment
denrase
left a comment
There was a problem hiding this comment.
Just one small suggestion.
| }); | ||
| }); | ||
|
|
||
| group('$isValidSampleRand', () { |
Collaborator
There was a problem hiding this comment.
+1 for adding test for previously untested functionality.
Collaborator
|
@buenaflor CI is failing: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d34233 | 1258.19 ms | 1268.92 ms | 10.73 ms |
| b6c8720 | 1252.65 ms | 1266.61 ms | 13.96 ms |
| 73a3c38 | 1263.37 ms | 1277.90 ms | 14.53 ms |
| 93b7728 | 1247.23 ms | 1264.87 ms | 17.64 ms |
| 0fb3800 | 1256.60 ms | 1266.28 ms | 9.68 ms |
| e2d675d | 1238.48 ms | 1242.76 ms | 4.28 ms |
| 9b99523 | 1256.06 ms | 1270.33 ms | 14.27 ms |
| 73dca78 | 1246.65 ms | 1265.42 ms | 18.76 ms |
| aeb02f2 | 1244.29 ms | 1256.55 ms | 12.26 ms |
| 6ba4675 | 1223.12 ms | 1238.17 ms | 15.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d34233 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| b6c8720 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73a3c38 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 93b7728 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0fb3800 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| e2d675d | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 9b99523 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 73dca78 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| aeb02f2 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6ba4675 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Previous results on branch: fix/span-ids-trace
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7887d07 | 1243.39 ms | 1263.16 ms | 19.78 ms |
| 6527881 | 1259.62 ms | 1266.16 ms | 6.54 ms |
| 0adaa4e | 1240.43 ms | 1261.94 ms | 21.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7887d07 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 6527881 | 7.86 MiB | 9.44 MiB | 1.58 MiB |
| 0adaa4e | 7.86 MiB | 9.44 MiB | 1.58 MiB |
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ba4675 | 499.80 ms | 632.43 ms | 132.63 ms |
| 2d34233 | 470.54 ms | 558.90 ms | 88.36 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
| 827bf09 | 475.40 ms | 547.14 ms | 71.74 ms |
| b6c8720 | 457.41 ms | 519.04 ms | 61.63 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| dbd526b | 504.88 ms | 569.02 ms | 64.15 ms |
| 640ad0c | 466.00 ms | 552.67 ms | 86.67 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6ba4675 | 6.54 MiB | 7.53 MiB | 1015.26 KiB |
| 2d34233 | 6.54 MiB | 7.55 MiB | 1.01 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 827bf09 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| b6c8720 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| dbd526b | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 640ad0c | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Previous results on branch: fix/span-ids-trace
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7887d07 | 470.67 ms | 548.98 ms | 78.31 ms |
| 6527881 | 444.98 ms | 522.31 ms | 77.33 ms |
| 0adaa4e | 489.91 ms | 545.98 ms | 56.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7887d07 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 6527881 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0adaa4e | 6.54 MiB | 7.69 MiB | 1.15 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Currently every trace header created from scope (propagation context), has the same span id.
We should always regenerate it. (same behaviour as in JS Browser)
💚 How did you test it?
Unit test, manual tests
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps