Skip to content

Remove SentryTimingsCallback and use Flutter's TimingsCallback instead #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 6 commits into from
Jul 10, 2025
Merged

Remove SentryTimingsCallback and use Flutter's TimingsCallback instead #3054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44c55bb
Update
buenaflor Jul 8, 2025
2cacd0a
Merge branch 'main' into refactor/use-timings-callback
buenaflor Jul 10, 2025
69f3420
Merge branch 'main' into refactor/use-timings-callback
buenaflor Jul 10, 2025
2b0d649
Update CHANGELOG
buenaflor Jul 10, 2025
ad3e034
Merge branch 'main' into refactor/use-timings-callback
buenaflor Jul 10, 2025
2580b41
Update CHANGELOG.md
buenaflor Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- `ScreenshotIntegration` not being added for web ([#3055](https://github.com/getsentry/sentry-dart/pull/3055))

### Enhancements

- Remove `SentryTimingsCallback` and use Flutter's `TimingsCallback` instead ([#3054](https://github.com/getsentry/sentry-dart/pull/3054))

## 9.4.0

### Fixes
Expand Down
11 changes: 4 additions & 7 deletions flutter/lib/src/frame_callback_handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/scheduler.dart';

/// Use instead of TimingsCallback as it is not available in the Flutter min version
typedef SentryTimingsCallback = void Function(List<FrameTiming> timings);

abstract class FrameCallbackHandler {
void addPostFrameCallback(FrameCallback callback);
void removeTimingsCallback(SentryTimingsCallback callback);
void addTimingsCallback(SentryTimingsCallback callback);
void removeTimingsCallback(TimingsCallback callback);
void addTimingsCallback(TimingsCallback callback);
}

class DefaultFrameCallbackHandler implements FrameCallbackHandler {
Expand All @@ -20,14 +17,14 @@ class DefaultFrameCallbackHandler implements FrameCallbackHandler {
}

@override
void addTimingsCallback(SentryTimingsCallback callback) {
void addTimingsCallback(TimingsCallback callback) {
try {
WidgetsBinding.instance.addTimingsCallback(callback);
} catch (_) {}
}

@override
void removeTimingsCallback(SentryTimingsCallback callback) {
void removeTimingsCallback(TimingsCallback callback) {
try {
WidgetsBinding.instance.removeTimingsCallback(callback);
} catch (_) {}
Expand Down
Loading