Skip to content

chore: fix flaky WidgetsBindingObserver test#3066

Merged
buenaflor merged 2 commits intomainfrom
test/fix-flakiness
Jul 11, 2025
Merged

chore: fix flaky WidgetsBindingObserver test#3066
buenaflor merged 2 commits intomainfrom
test/fix-flakiness

Conversation

@buenaflor
Copy link
Copy Markdown
Contributor

#skip-changelog

the flaky test should not be running in web environments

@buenaflor buenaflor changed the title test: fix flaky WidgetsBindingObserver test chore: fix flaky WidgetsBindingObserver test Jul 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (b24cd9c) to head (d4381d1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3066      +/-   ##
==========================================
+ Coverage   87.98%   89.82%   +1.83%     
==========================================
  Files         287       96     -191     
  Lines        9533     3331    -6202     
==========================================
- Hits         8388     2992    -5396     
+ Misses       1145      339     -806     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 457.21 ms 575.96 ms 118.74 ms
Size 6.54 MiB 7.69 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
640ad0c 466.00 ms 552.67 ms 86.67 ms
9b99523 456.91 ms 490.55 ms 33.64 ms
aeb02f2 373.84 ms 437.00 ms 63.16 ms
73dca78 476.53 ms 522.21 ms 45.68 ms
c8596a6 474.00 ms 492.96 ms 18.96 ms
93b7728 475.28 ms 489.13 ms 13.86 ms
6ba4675 499.80 ms 632.43 ms 132.63 ms
b6c8720 457.41 ms 519.04 ms 61.63 ms
0fb3800 465.64 ms 536.77 ms 71.13 ms
827bf09 475.40 ms 547.14 ms 71.74 ms

App size

Revision Plain With Sentry Diff
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
9b99523 6.54 MiB 7.69 MiB 1.15 MiB
aeb02f2 6.54 MiB 7.69 MiB 1.15 MiB
73dca78 6.54 MiB 7.69 MiB 1.15 MiB
c8596a6 6.54 MiB 7.53 MiB 1015.27 KiB
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
6ba4675 6.54 MiB 7.53 MiB 1015.26 KiB
b6c8720 6.54 MiB 7.69 MiB 1.15 MiB
0fb3800 6.54 MiB 7.69 MiB 1.15 MiB
827bf09 6.54 MiB 7.53 MiB 1015.27 KiB

@github-actions
Copy link
Copy Markdown
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.14 ms 1270.53 ms 21.39 ms
Size 7.86 MiB 9.44 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2d675d 1238.48 ms 1242.76 ms 4.28 ms
9b99523 1256.06 ms 1270.33 ms 14.27 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
aeb02f2 1244.29 ms 1256.55 ms 12.26 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
dbd526b 1244.78 ms 1259.02 ms 14.24 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
640ad0c 1241.04 ms 1253.96 ms 12.92 ms

App size

Revision Plain With Sentry Diff
e2d675d 7.86 MiB 9.44 MiB 1.58 MiB
9b99523 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
aeb02f2 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
dbd526b 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
640ad0c 7.86 MiB 9.44 MiB 1.58 MiB

@buenaflor buenaflor merged commit 73a3c38 into main Jul 11, 2025
69 checks passed
@buenaflor buenaflor deleted the test/fix-flakiness branch July 11, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants