Implement sampled flag in propagation context#3084
Merged
Conversation
Co-authored-by: giancarlo.buenaflor <giancarlo.buenaflor@sentry.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
==========================================
- Coverage 87.90% 87.79% -0.12%
==========================================
Files 287 287
Lines 9754 9763 +9
==========================================
- Hits 8574 8571 -3
- Misses 1180 1192 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575ebaa | 478.00 ms | 585.76 ms | 107.76 ms |
| ec78888 | 457.94 ms | 519.96 ms | 62.02 ms |
| 81f83eb | 471.40 ms | 522.14 ms | 50.74 ms |
| 0fb3800 | 465.64 ms | 536.77 ms | 71.13 ms |
| e2d675d | 457.92 ms | 529.17 ms | 71.25 ms |
| 9b99523 | 456.91 ms | 490.55 ms | 33.64 ms |
| c8596a6 | 474.00 ms | 492.96 ms | 18.96 ms |
| 73dca78 | 476.53 ms | 522.21 ms | 45.68 ms |
| 793f4dc | 462.68 ms | 544.21 ms | 81.53 ms |
| 93b7728 | 475.28 ms | 489.13 ms | 13.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 575ebaa | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| ec78888 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 81f83eb | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 0fb3800 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| e2d675d | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 9b99523 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| c8596a6 | 6.54 MiB | 7.53 MiB | 1015.27 KiB |
| 73dca78 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 793f4dc | 6.54 MiB | 7.69 MiB | 1.15 MiB |
| 93b7728 | 6.54 MiB | 7.69 MiB | 1.15 MiB |
Contributor
Author
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
buenaflor
deleted the
cursor/implement-sampled-flag-in-propagation-context-1420
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds a
sampledflag toPropagationContextto indicate if the current trace is sampled.💡 Motivation and Context
In HTTP calls we just reference the propagation context sampled and propagate that in the sentry-trace
💚 How did you test it
Unit test, manual testing
📝 Checklist
sendDefaultPiiis enabled