feat(span-first): Add TTID/TTFD instrumentation by buenaflor · Pull Request #3532 · getsentry/sentry-dart

buenaflor · 2026-02-19T20:56:30Z

📜 Description

Adds streaming route TTID/TTFD span tracking (TimeToDisplayTrackerV2) and wires it through Flutter navigation/display APIs.

💡 Motivation and Context

Part of Span First of porting TTID/TTFD

💚 How did you test it?

fvm flutter test test/navigation/time_to_display_tracker_v2_test.dart test/navigation/sentry_navigator_observer_test.dart
Manual tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace inline TTID/TTFD streaming code in SentryNavigatorObserver with TimeToDisplayTrackerV2.trackRoute(). Remove static ttfdSpan field and route SentryDisplay/SentryFlutter.currentDisplay() through the tracker on SentryFlutterOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…aming integration tests Make timeToDisplayTrackerV2 a non-nullable late field on SentryFlutterOptions instead of being created and set by SentryNavigatorObserver. Add didPop handling for streaming mode and integration tests covering the full span v2 TTID/TTFD lifecycle through the navigator observer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-19T20:56:58Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 191cc16

buenaflor · 2026-02-20T09:42:25Z

@sentry review

buenaflor · 2026-02-20T09:42:29Z

@cursor review

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart

buenaflor · 2026-02-20T10:32:57Z

@cursor review

buenaflor · 2026-02-20T10:33:02Z

@sentry review

packages/flutter/lib/src/navigation/sentry_display.dart

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart

Copilot

Pull request overview

This PR adds streaming-mode TTID (Time To Initial Display) and TTFD (Time To Full Display) instrumentation for Flutter navigation. It introduces TimeToDisplayTrackerV2 which uses the new span-first architecture with idle spans to track route display timing, alongside conditional routing logic to support both legacy and streaming trace lifecycles.

Changes:

Added TimeToDisplayTrackerV2 class for streaming-mode TTID/TTFD tracking using idle spans
Updated Flutter navigation observer and display APIs to conditionally use V2 tracker when in streaming mode
Changed default idle span timeout from 5 seconds to 3 seconds across the SDK

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/flutter/lib/src/navigation/time_to_display_tracker_v2.dart	New tracker implementation using idle spans for route-level TTID/TTFD tracking
packages/flutter/lib/src/sentry_flutter_options.dart	Added timeToDisplayTrackerV2 field initialization
packages/flutter/lib/src/sentry_flutter.dart	Updated currentDisplay() to conditionally return V2 span IDs in streaming mode
packages/flutter/lib/src/navigation/sentry_navigator_observer.dart	Added V2 tracker initialization and conditional routing in didPush/didPop
packages/flutter/lib/src/navigation/sentry_display.dart	Updated reportFullyDisplayed() to conditionally call V2 tracker and improved error logging
packages/dart/lib/src/noop_hub.dart	Changed startIdleSpan default idleTimeout from 5s to 3s
packages/dart/lib/src/hub_adapter.dart	Changed startIdleSpan default idleTimeout from 5s to 3s
packages/flutter/example/lib/auto_close_screen.dart	Moved Dio instance to class field (lifecycle change)
packages/flutter/test/navigation/time_to_display_tracker_v2_test.dart	Comprehensive unit tests for TimeToDisplayTrackerV2
packages/flutter/test/navigation/sentry_navigator_observer_test.dart	Added streaming mode integration tests
packages/flutter/test/navigation/sentry_display_test.dart	Added tests for both streaming and non-streaming modes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/dart/lib/src/noop_hub.dart

packages/flutter/example/lib/auto_close_screen.dart

buenaflor · 2026-02-20T11:52:07Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

buenaflor · 2026-02-20T12:05:34Z

packages/dart/lib/src/hub_adapter.dart

  SentrySpanV2 startIdleSpan(
    String name, {
-    Duration idleTimeout = const Duration(seconds: 5),
+    Duration idleTimeout = const Duration(seconds: 3),


default should be 3 seconds

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart

packages/dart/lib/src/hub_adapter.dart

packages/flutter/test/navigation/sentry_navigator_observer_test.dart

packages/flutter/lib/src/navigation/time_to_display_tracker_v2.dart

packages/flutter/test/navigation/time_to_display_tracker_v2_test.dart

…ming tests Guard TTFD span creation behind enableTimeToFullDisplayTracing option. Refactor observer streaming tests to use a fake tracker, verifying method calls instead of re-testing tracker internals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

packages/flutter/lib/src/navigation/time_to_display_tracker_v2.dart

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

packages/flutter/lib/src/sentry_flutter.dart

Implement a debug log to indicate when Time To Full Display (TTFD) tracing is disabled, returning null for currentDisplay accordingly. This enhances traceability and debugging for TTFD-related functionality.

…et test currentDisplay() now guards on this option, so the test fixture needs it set to true for reportFullyDisplayed to be called. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

buenaflor and others added 3 commits February 19, 2026 21:17

feat(flutter): Add TimeToDisplayTrackerV2 for streaming TTID/TTFD

e7d39c8

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Update logger and example

44dcb96

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart Outdated Show resolved Hide resolved

buenaflor added 3 commits February 20, 2026 11:01

Review

c0f9d6d

Review

14d6df2

Review

9d03dee

Fix test

4d81a0f

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/flutter/lib/src/navigation/sentry_display.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart Outdated Show resolved Hide resolved

buenaflor and others added 3 commits February 20, 2026 12:11

Review

027b043

Merge branch 'feat/span-first' into feat/span/ttid-ttfd

fcaa139

Update

414f04c

buenaflor marked this pull request as ready for review February 20, 2026 11:34

buenaflor requested a review from denrase as a code owner February 20, 2026 11:34

Copilot AI review requested due to automatic review settings February 20, 2026 11:34

Copilot started reviewing on behalf of buenaflor February 20, 2026 11:35 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

packages/dart/lib/src/noop_hub.dart Show resolved Hide resolved

packages/flutter/example/lib/auto_close_screen.dart Outdated Show resolved Hide resolved

cursor bot reviewed Feb 20, 2026

View reviewed changes

buenaflor commented Feb 20, 2026

View reviewed changes

Update

4a8b74b

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/flutter/lib/src/navigation/sentry_navigator_observer.dart Outdated Show resolved Hide resolved

buenaflor added 2 commits February 20, 2026 13:32

review

7768434

review

478f9ec

Update

fe07028

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/dart/lib/src/hub_adapter.dart Show resolved Hide resolved

denrase requested changes Feb 23, 2026

View reviewed changes

buenaflor and others added 2 commits February 23, 2026 13:55

refactor(tracing): Use Dart 3 object pattern for TTFD option check

465c983

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry bot reviewed Feb 23, 2026

View reviewed changes

packages/flutter/lib/src/navigation/time_to_display_tracker_v2.dart Show resolved Hide resolved

denrase approved these changes Feb 23, 2026

View reviewed changes

cursor bot reviewed Feb 23, 2026

View reviewed changes

packages/flutter/lib/src/sentry_flutter.dart Show resolved Hide resolved

buenaflor and others added 3 commits February 23, 2026 14:16

feat(tracing): Add debug logging for TTFD option check

6956632

Implement a debug log to indicate when Time To Full Display (TTFD) tracing is disabled, returning null for currentDisplay accordingly. This enhances traceability and debugging for TTFD-related functionality.

fix(test): Enable enableTimeToFullDisplayTracing in SentryDisplayWidg…

016e594

…et test currentDisplay() now guards on this option, so the test fixture needs it set to true for reportFullyDisplayed to be called. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Analyze

191cc16

buenaflor merged commit 5acb39e into feat/span-first Feb 23, 2026
140 checks passed

buenaflor deleted the feat/span/ttid-ttfd branch February 23, 2026 15:08

Uh oh!

Conversation

buenaflor commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

buenaflor commented Feb 20, 2026

Uh oh!

buenaflor commented Feb 20, 2026

Uh oh!

Uh oh!

buenaflor commented Feb 20, 2026

Uh oh!

buenaflor commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

buenaflor commented Feb 20, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

buenaflor Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

buenaflor commented Feb 19, 2026 •

edited

Loading

github-actions bot commented Feb 19, 2026 •

edited

Loading