build: fetch sentry-native from release zip#3621
Conversation
Use the pre-packaged release zip instead of git clone to avoid dependency on chromium.googlesource.com which is unreliable (HTTP 429 rate limits in CI). See getsentry/sentry-native#1625 Co-Authored-By: Claude <noreply@anthropic.com>
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
CONTRIBUTING.md contains the words "maintainer" and "issue" 0 times. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
+ Coverage 86.83% 91.80% +4.96%
==========================================
Files 320 102 -218
Lines 10789 3479 -7310
==========================================
- Hits 9369 3194 -6175
+ Misses 1420 285 -1135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We'll go ahead with this. CI failures are unrelated to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 946c132. Configure here.
| sentry-native | ||
| GIT_REPOSITORY ${SENTRY_NATIVE_repo} | ||
| GIT_TAG ${SENTRY_NATIVE_version} | ||
| URL ${SENTRY_NATIVE_URL} |
There was a problem hiding this comment.
Missing URL_HASH for downloaded dependency archive
Medium Severity
The sentry-native FetchContent_Declare uses a direct URL download without a URL_HASH parameter. This means the downloaded sentry-native.zip lacks integrity verification, unlike the previous Git method. This introduces a supply chain risk for a security SDK, as CMake documentation recommends URL_HASH for remote fetches.
Triggered by project rule: PR Review Guidelines for Cursor Bot (Root)
Reviewed by Cursor Bugbot for commit 946c132. Configure here.


📜 Description
Use the pre-packaged release zip instead of git clone to avoid dependency on chromium.googlesource.com which is unreliable.
💡 Motivation and Context
See getsentry/sentry-native#1625
💚 How did you test it?
Tested by integrating the fork into a Flutter desktop app (Windows) that previously failed to build due to chromium.googlesource.com being unavailable — the build now completes successfully using the release zip.
📝 Checklist
sendDefaultPiiis enabled#skip-changelog