chore(demo): Replace auto-sending metrics with a tool button#623
Merged
chore(demo): Replace auto-sending metrics with a tool button#623
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Collaborator
Author
|
Reading console output is challenging while having demo metrics enabled all the time. |
jpnurmi
approved these changes
Apr 1, 2026
JoshuaMoelans
approved these changes
Apr 1, 2026
tustanivsky
approved these changes
Apr 1, 2026
mujacica
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending metrics by default creates some noise in the output, which may distract from other things happening in the demo project. This PR makes sending metrics a tool action, which toggles sending. To start sending metrics, you now need to press the corresponding tool button, and you can stop sending metrics by pressing it again.