feat(editor): Add iOS export warning for minimum version#628
Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Warning message hardcodes version instead of using constant
- The warning text now stringifies
SENTRY_IOS_MIN_VERSION, so the displayed minimum iOS version always matches the comparison threshold.
- The warning text now stringifies
Or push these changes by commenting:
@cursor push f6e886e12c
Preview (f6e886e12c)
diff --git a/src/editor/sentry_editor_export_plugin_ios.cpp b/src/editor/sentry_editor_export_plugin_ios.cpp
--- a/src/editor/sentry_editor_export_plugin_ios.cpp
+++ b/src/editor/sentry_editor_export_plugin_ios.cpp
@@ -5,6 +5,9 @@
#include "export_utils.h"
#include "gen/sdk_version.gen.h"
+#define SENTRY_STRINGIFY_HELPER(x) #x
+#define SENTRY_STRINGIFY(x) SENTRY_STRINGIFY_HELPER(x)
+
using namespace sentry::editor;
String SentryEditorExportPluginIOS::_get_name() const {
@@ -27,7 +30,7 @@
if (is_builtin_option_or_hidden_export_option(p_option, "application/min_ios_version")) {
String min_ios_version = get_option("application/min_ios_version");
if (min_ios_version.to_float() < SENTRY_IOS_MIN_VERSION) {
- return "Sentry requires \"Min iOS version\" 15.0 or higher. Please adjust this setting.";
+ return "Sentry requires \"Min iOS version\" " SENTRY_STRINGIFY(SENTRY_IOS_MIN_VERSION) " or higher. Please adjust this setting.";
}
}
return String();This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
jpnurmi
approved these changes
Apr 3, 2026
Co-authored-by: J-P Nurmi <jpnurmi@gmail.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn users when iOS "Min iOS version" is below 15.0 required by Sentry Cocoa SDK. FYI, Godot default is
14.0.Also extracts the hidden export option hack into shared helpers in
export_utils.hto reduce duplication across Android, Web, and iOS export plugins (3rd time the same pattern is used).