Taskfile: Add "tidy" for simple find-replace cleanup of package.yml - #10671
davidjharder wants to merge 1 commit into
Conversation
|
I have called this command "tidy" but if anyone has better ideas, open to them |
| - sed -i 's/install -Dm00644/%install_file/g' package.yml # install files | ||
| - sed -i 's/install -Dm 00644/%install_file/g' package.yml | ||
| - sed -i 's/install -D -m 00644/%install_file/g' package.yml | ||
| - sed -i 's/install -D -m644/%install_file/g' package.yml |
There was a problem hiding this comment.
I wonder if all of these could be simplified to just install -D.+644, or install -D*644
|
I'm a little hesitant about the macro swaps, because I've encountered a few times where the |
|
IMO it's a fine trade-off for automating the donkey work of swapping in the macros. Doing it automatically shouldn't add any packaging errors that weren't there already. I'll investigate if the search targets can use some wildcards |
Summary
$pkgfiles->${pkgfiles}install -Dm00644->%install_fileinstall -dm00755->%install_dirinstall -Dm00755->%install_exe FIXME_EXE_or_BIN. Becuase a simple find and replace can't be trusted with fixing the install commands for executables, drop in a FIXME that will remind the packager to pick the correct macro and edit accordinglyTest Plan
Checklist