Disable fat LTO objects by default, detect LTO built .a/.o files - #159
Draft
joebonrichie wants to merge 1 commit into
Draft
Disable fat LTO objects by default, detect LTO built .a/.o files#159joebonrichie wants to merge 1 commit into
joebonrichie wants to merge 1 commit into
Conversation
When building with LTO, disable fat-lto-objects by default in favour of slim LTO objects. Building with fat LTO objects by default significantly increases build time to catch the rare cases when we do actually ship static files in a package when building with LTO. Instead, detect any static files or object files containing only LTO bytecode and warn the packager the offending file(s) must be removed or rebuilt with fat-lto-objects. This way we can significantly reduce build times and disk usage when LTO is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When building with LTO, disable fat-lto-objects by default in favour of slim LTO objects.
Building with fat LTO objects by default significantly increases build time to catch the rare cases when we do actually ship static files in a package when building with LTO.
Instead, detect any static files or object files containing only LTO bytecode and warn the packager the offending file(s) must be removed or rebuilt with fat-lto-objects.
This way we can significantly reduce build times and disk usage when LTO is enabled.
Test Plan
Build packages with GCC LTO, clang thin LTO, clang fat LTO, ensure static files built without fat-lto-objects were caught.