fix: crewai examples, bump dependencies - #421
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5d136bd in 2 minutes and 31 seconds. Click for details.
- Reviewed
274lines of code in8files - Skipped
0files when reviewing. - Skipped posting
11draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. integrations/python/zep_crewai/examples/crewai_graph.py:16
- Draft comment:
Importing 'SearchFilters' improves type safety for search filters. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states a fact about the code change without offering any guidance or questions for the PR author.
2. integrations/python/zep_crewai/examples/crewai_graph.py:57
- Draft comment:
Explicitly creating the graph before setting the ontology ensures the graph exists as expected. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states what the code is doing without offering any critique or advice.
3. integrations/python/zep_crewai/examples/crewai_graph.py:66
- Draft comment:
Updated ontology setup: using 'graph_ids' as a list aligns with the expected API contract. Verify that this change is compatible with the underlying API. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify compatibility with the underlying API, which violates the rule against asking for confirmation or verification of intentions. It does not provide a specific suggestion or point out a clear issue.
4. integrations/python/zep_crewai/examples/crewai_graph.py:81
- Draft comment:
Using a SearchFilters instance (instead of a raw dict) for search_filters enhances validation and clarity. - Reason this comment was not posted:
Comment looked like it was already resolved.
5. integrations/python/zep_crewai/examples/crewai_tools.py:40
- Draft comment:
User creation was simplified by removing duplicate handling. Ensure that duplicate users (if already existing) are managed appropriately by the Zep API. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =50%<= threshold50%The comment is asking the author to ensure that duplicate users are managed appropriately by the Zep API. This is a request for confirmation of behavior, which violates the rule against asking the author to ensure behavior is intended. However, it does point out a potential issue with duplicate handling, which could be useful.
6. integrations/python/zep_crewai/pyproject.toml:3
- Draft comment:
Bumped version to 1.0.0 and updated the zep-cloud dependency to >=3.4.1. Ensure this aligns with the release notes and backward compatibility. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about a version bump and dependency update, which falls under the rule of not commenting on pure dependency changes. The suggestion to ensure alignment with release notes and backward compatibility is also a form of asking the author to double-check things, which is not allowed.
7. integrations/python/zep_crewai/src/zep_crewai/graph_storage.py:115
- Draft comment:
The search method now wraps its operations in a try/except block and returns results with a 'memory' key (instead of 'context'), which improves error handling and consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, describing changes made to the code without suggesting any improvements or asking for clarification. It doesn't align with the rules for useful comments.
8. integrations/python/zep_crewai/src/zep_crewai/tools.py:170
- Draft comment:
Enhanced search tool result formatting now prioritizes the 'memory' field (with fallbacks to 'context' and 'content'), which aids compatibility with updated storage return values. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining the changes made to the search tool result formatting. It doesn't provide any actionable feedback or suggestions for improvement.
9. integrations/python/zep_crewai/src/zep_crewai/user_storage.py:157
- Draft comment:
User storage search now returns a result with the 'memory' key, ensuring consistency with the graph storage changes. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, describing a change without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.
10. integrations/python/zep_crewai/tests/test_graph_storage.py:128
- Draft comment:
Test updated to assert on the 'memory' field (instead of 'context'), which aligns with the refactored search method. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining what was changed in the test. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. According to the rules, purely informative comments should be removed.
11. integrations/python/zep_crewai/tests/test_user_storage.py:134
- Draft comment:
Tests for user storage have been updated to assert on the 'memory' key in search results, ensuring consistency with the updated implementation. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_GjDvBdlz94WVCo6j
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 84662e0 in 1 minute and 3 seconds. Click for details.
- Reviewed
68lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. integrations/python/zep_crewai/README.md:362
- Draft comment:
Updated to 'data processing'; ensure consistency with backend terminology. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. integrations/python/zep_crewai/examples/crewai_graph.py:142
- Draft comment:
Revised wait message to 'data processing' for consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. integrations/python/zep_crewai/examples/crewai_tools.py:142
- Draft comment:
Changed wait message to 'data processing'; looks consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. integrations/python/zep_crewai/examples/crewai_user.py:146
- Draft comment:
Updated wait message to 'data processing' for uniformity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. integrations/python/zep_crewai/src/zep_crewai/tools.py:169
- Draft comment:
Direct lookup of 'content' and 'created_at' without fallback; ensure these keys are always present. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_ZNkUcDEXArgwj7Ja
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fix CrewAI examples, update dependencies, and improve error handling in search methods.
crewai_graph.py: Addzep_client.graph.create()for graph initialization and updateset_ontology()to usegraph_idslist.crewai_tools.py: Simplify user creation by removing exception handling for existing users.crewai_user.py: Update user creation to handle existing users more gracefully.zep-cloudto>=3.4.1inpyproject.toml.1.0.0inpyproject.toml.graph_storage.pyanduser_storage.py: Add error handling insearch()methods.contexttomemoryin search results.test_graph_storage.pyandtest_user_storage.pyto reflect changes in search result keys.This description was created by
for 84662e0. You can customize this summary. It will automatically update as commits are pushed.