Conversation
|
Nice! I think the changelog diff is a bit incorrect: it marks as released in v29 everything currently marked as unreleased, which isn't the case (there were new additions after v29). Apparently the current changelog in trunk contains both pre-v29 and post-v29 changes. Maybe just add your changes to unreleased for now, and then a separate PR would sort out the changelog itself? |
|
yeah, I quickly looked at the blame and all your recentt changes should probably move to the top as well. I just tried to have mine a little more correct for now. I can add a commit to move yours tomorrow, or maybe do it outside this PR? |
|
I'd suggest fixing the changelog in a separate PR, just to keep the history clean? |
| /** Identifies @ref WGPUNativeLimits. */ | ||
| WGPUSType_NativeLimits = 0x00030002, | ||
| /** Identifies @ref WGPUPipelineLayoutExtras. */ | ||
| WGPUSType_PipelineLayoutExtras = 0x00030003, |
There was a problem hiding this comment.
as this enum is removed, do all the others need to move up?
Checklist
cargo clippyreports no issuescargo docreports no issuescargo denyissues have been fixed or added todeny.tomlAdded new functionality. @githubnameDescription
While doing the v29 update for the python wrapper. I spotted that the descriptor already has a
immediateSizefield inwebgpu.hwebgpu-native/webgpu-headers#529Also saw the limits being simplified in #575 so this makes it even simpler, although you still need the native only feature. I updated the example and it still works, please let me know if the changes to the
wgpu.hheaders are fine like this.Related Issues