Skip to content

fix(core): Fix corner cases in initialized range tracking - #10002

Open
andyleiserson wants to merge 1 commit into
gfx-rs:trunkfrom
andyleiserson:jj-push-lpvu
Open

fix(core): Fix corner cases in initialized range tracking#10002
andyleiserson wants to merge 1 commit into
gfx-rs:trunkfrom
andyleiserson:jj-push-lpvu

Conversation

@andyleiserson

@andyleiserson andyleiserson commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Adds a proptest for the uninitialized range tracker, and fixes a few corner cases.

This does add a new dev-dependency on proptest; I think these are good tests and this probably isn't the only place where we could benefit, but every dependency costs something.

Testing
The proptest; also includes directed tests for the fixes.

Squash or Rebase? Squash

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

Comment thread Cargo.toml
Comment on lines +181 to +182
# Limit to versions that use rand 0.8
proptest = ">=1, <1.7"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like our use of rand 0.8 is via noise, for the water example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant