Skip to content

fix(changelog): detect deleted release sections - #9255

Merged
ErichDonGubler merged 5 commits into
gfx-rs:trunkfrom
teddygood:fix-changelog-deleted-release-sections
Jul 7, 2026
Merged

fix(changelog): detect deleted release sections#9255
ErichDonGubler merged 5 commits into
gfx-rs:trunkfrom
teddygood:fix-changelog-deleted-release-sections

Conversation

@teddygood

@teddygood teddygood commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Connections
Fixes #9245.

Description
The changelog check previously only used post-change line positions, which let deletions of already-released sections slip through. This switches the check to track both old and new hunk positions and adds a regression test.

@teddygood
teddygood force-pushed the fix-changelog-deleted-release-sections branch from cca1f97 to 575cf24 Compare March 18, 2026 10:01
@teddygood
teddygood force-pushed the fix-changelog-deleted-release-sections branch from 575cf24 to b7a30db Compare March 18, 2026 10:06
@ErichDonGubler ErichDonGubler self-assigned this Mar 18, 2026
@ErichDonGubler

Copy link
Copy Markdown
Member

I'll take on reviewing this, though I likely won't be able to finish a review until early next week.

I've updated the OP to remove the PR checklist, since it's not useful here.

@ErichDonGubler ErichDonGubler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've let this PR languish, and I apologize. I've failed to honor reasonable expectations for review. wgpu maintainership expects better WRT communication, and that's on me.

It's been hard to prioritize, with (1) an international move of me and my whole family with young kids, (2) other more pressing issues in the repo, and (3) a recent development with #9779 noting that we might move away from a single CHANGELOG file to having multiple RustDoc modules specifically for documentation.

I think this code is good enough that I'm going to merge it. Thanks for your first contribution to wgpu! 🌟❤️

@ErichDonGubler
ErichDonGubler merged commit 92ce3d4 into gfx-rs:trunk Jul 7, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CHANGELOG check in CI doesn't check for deleted release sections

2 participants