add Metal support for `MULTISAMPLE_ARRAY` by 39ali · Pull Request #9300 · gfx-rs/wgpu

39ali · 2026-03-25T11:42:24Z

Connections
#8593

Description
add Metal support for MULTISAMPLE_ARRAY

Testing
no tests where added

Squash or Rebase?

Checklist

Run cargo fmt.
Run taplo format.
Run cargo clippy --tests. If applicable, add:
- --target wasm32-unknown-unknown
Run cargo xtask test to run tests.
If this contains user-facing changes, add a CHANGELOG.md entry.

inner-daemons

2 nits, generally looks good

inner-daemons

This would also need a changelog entry just FYI.

But I actually have bigger concerns, which is that I have absolutely zero clue where you got the requirements from. Ctrl+f looking for "multisample` only pops up 3 items in the feature set tables, and the only non-footnote item is "Layered rendering to multisample textures", which seems related but also the limits there don't match what you did at all.

The fact that you referenced "Mac Family 1" also does not inspire confidence because that has been scrubbed for a while now from the tables.

If you can share a link to the archive.org page you were referencing that would be ideal (assuming you were actually looking at such a page).

inner-daemons · 2026-03-26T17:03:54Z

+                // Multisample 2D Array textures are supported on:
+                // - Apple Family 3 and higher (A10 chips/iPhone 7 and newer)
+                // - Mac Family 1 and higher (All Intel/AMD/Apple Silicon Macs)
+                if available!(macos = 10.14, ios = 14.0, tvos = 16.0, visionos = 1.0) {


This should also require family_check or supportsFamily will crash.

inner-daemons · 2026-03-26T17:06:27Z

+                // Multisample 2D Array textures are supported on:
+                // - Apple Family 3 and higher (A10 chips/iPhone 7 and newer)
+                // - Mac Family 1 and higher (All Intel/AMD/Apple Silicon Macs)


I'm not seeing anything in the metal feature set tables about multisample 2D array textures. What is the exact feature called?

Also, the metal feature set tables have scrubbed all references of "Mac Family 1" a while ago, so are you looking at some older version of this on the internet archive?

inner-daemons · 2026-03-26T17:22:33Z

Just to be more transparent, my big concern here is that you vibecoded this PR and never bothered to check the references your LLM provided. I hope that's not true though and you can provide the document used.

39ali · 2026-03-27T06:13:56Z

@inner-daemons i actually hit the same issue when i was looking at the minimum req for this since there's no specific place that connects multisample to gpu family , so i had to do a bit of connecting by myself, so i looked at https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf : Metal 2 and later support 2D multisampled texture array
then i looked at https://gist.github.com/schwa/3893c225133fd93ae869492ff8fa1610 to connect the metal version to the gpu family, i might be wrong and i'm happy to fix whatever is the issue if

39ali · 2026-03-27T06:20:21Z

@inner-daemons i looked at MoltenVK since they do also have to target it, it looks like they just support it across the board if it's not TVOS ,https://github.com/KhronosGroup/MoltenVK/blob/c0d41c221b3903519c83753e559452d9a81ee286/MoltenVK/MoltenVK/GPUObjects/MVKDevice.mm#L2463

we could do the same as well

inner-daemons · 2026-03-27T07:53:13Z

@39ali What was the reasoning for this comment?

                // According to Metal Feature Set Tables:

I don't think that the feature set tables are relevant here?

And yes i will check on the sources you linked.

39ali · 2026-03-28T17:13:36Z

@inner-daemons the gist references it, but i do agree it's a bit confusing, i'll fix it according to what we decide to do

inner-daemons · 2026-03-30T20:22:46Z

Ok so I think that for feature support we only need to check for the OS versions in https://developer.apple.com/documentation/metal/mtltexturetype/type2dmultisamplearray.

As for the MSL side, it looks like the specifics are mainly for reading multisampled textures, which is not an operation I'm familiar with? If that requires new MSL features then our MSL writer needs to be updated and those changes should require a certain language version. Otherwise should be left alone.

inner-daemons · 2026-03-30T20:30:12Z

Filed #9342

39ali · 2026-04-01T10:53:12Z

@inner-daemons okay so i modified the check for MTLTextureType.type2DMultisampleArray support
and we can handle the support for msl in a pr for #9342

inner-daemons

LGTM, take a look @cwfitzgerald

inner-daemons · 2026-04-06T06:15:18Z

@39ali Do you have a discord or matrix account? I'd like to ask you about something, my handle on discord is inner_daemons and on matrix it's @supamaggie70:matrix.org.

39ali · 2026-04-06T08:13:48Z

@inner-daemons discord sent

39ali · 2026-04-08T11:49:14Z

@ErichDonGubler ready

cwfitzgerald

One nit, then g2g

cwfitzgerald · 2026-04-09T00:50:12Z


        features.set(F::EXPERIMENTAL_RAY_QUERY, self.supports_raytracing);

+        features.set(F::MULTISAMPLE_ARRAY, self.supports_multisample_array);


The docs of this feature need to be expanded to show metal support as well.

@cwfitzgerald should be good to go

cwfitzgerald assigned cwfitzgerald and inner-daemons Mar 25, 2026

inner-daemons self-requested a review March 25, 2026 15:35

inner-daemons suggested changes Mar 25, 2026

View reviewed changes

Comment thread wgpu-hal/src/metal/adapter.rs Outdated

Comment thread wgpu-hal/src/metal/adapter.rs Outdated

inner-daemons suggested changes Mar 26, 2026

View reviewed changes

39ali force-pushed the metal-multisample-array branch from 89d7ca4 to 5bd4491 Compare April 1, 2026 10:51

39ali force-pushed the metal-multisample-array branch 2 times, most recently from ea3f11c to 5360ac0 Compare April 2, 2026 11:00

inner-daemons approved these changes Apr 2, 2026

View reviewed changes

inner-daemons requested a review from cwfitzgerald April 2, 2026 16:58

39ali added 3 commits April 8, 2026 11:50

add Metal support for MULTISAMPLE_ARRAY

36f2ea8

cleanup

b73884c

check for MTLTextureType.type2DMultisampleArray support

18b93e6

39ali force-pushed the metal-multisample-array branch from 5360ac0 to 18b93e6 Compare April 8, 2026 08:50

cwfitzgerald approved these changes Apr 9, 2026

View reviewed changes

updated doc

c1135d5

cwfitzgerald approved these changes Apr 9, 2026

View reviewed changes

cwfitzgerald merged commit bde7091 into gfx-rs:trunk Apr 9, 2026
58 checks passed

inner-daemons mentioned this pull request Apr 20, 2026

Metal support for MULTISAMPLE_ARRAY. #8593

Closed

slyedoc pushed a commit to slyedoc/wgpu that referenced this pull request May 28, 2026

add Metal support for MULTISAMPLE_ARRAY (gfx-rs#9300)

acc88f9


		features.set(F::EXPERIMENTAL_RAY_QUERY, self.supports_raytracing);

		features.set(F::MULTISAMPLE_ARRAY, self.supports_multisample_array);

Uh oh!

Conversation

39ali commented Mar 25, 2026

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inner-daemons left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inner-daemons Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

inner-daemons Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

inner-daemons commented Mar 26, 2026

Uh oh!

39ali commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

39ali commented Mar 27, 2026

Uh oh!

inner-daemons commented Mar 27, 2026

Uh oh!

39ali commented Mar 28, 2026

Uh oh!

inner-daemons commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inner-daemons commented Mar 30, 2026

Uh oh!

39ali commented Apr 1, 2026

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

inner-daemons commented Apr 6, 2026

Uh oh!

39ali commented Apr 6, 2026

Uh oh!

39ali commented Apr 8, 2026

Uh oh!

cwfitzgerald left a comment

Choose a reason for hiding this comment

Uh oh!

cwfitzgerald Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

39ali Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

inner-daemons left a comment •

edited

Loading

39ali commented Mar 27, 2026 •

edited

Loading

inner-daemons commented Mar 30, 2026 •

edited

Loading