[msl-out] Switch to intersection queries - #9304
Merged
Merged
Conversation
6 tasks
Contributor
|
Just checked if the |
Vecvec
force-pushed
the
change-macos-rq
branch
5 times, most recently
from
April 1, 2026 20:47
a96f4f7 to
2bb591c
Compare
cwfitzgerald
approved these changes
Apr 15, 2026
| return Err(Error::UnsupportedRayTracing); | ||
| } | ||
|
|
||
| // TODO: check for misuse. |
Member
There was a problem hiding this comment.
Should these TODOs get issues?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Description
Re-writes the msl naga backend to use intersection queries instead of the intersector. This provides the notable benefit of supporting AABBs and non-opaque triangles. It also behave more like ray queries. The intersector matches ray tracing pipelines more than ray queries (though w/ significant differences).
Testing
Ran existing tests with shader validation disabled (which seems to help #9100 ).
Squash or Rebase?
Squash: this was originally started to see if it helped #9100, so I was initially ignoring CI failures .
Checklist
cargo fmt.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.