Enable ray tracing example tests on metal - #9324
Merged
Merged
Conversation
Vecvec
force-pushed
the
disable-mtl-val
branch
2 times, most recently
from
April 1, 2026 00:14
7b3f054 to
1443fd3
Compare
Contributor
Author
|
macOS 26.4 seems to fix the issue, but I think that this still might be worthwhile for testing on other versions. |
inner-daemons
self-requested a review
April 1, 2026 15:44
inner-daemons
removed their request for review
April 1, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Prevents #9100 from happening on tests.
Description
Disables metal shader validation (see #9100 (comment)) on the ray tracing examples as it seems to fail to map the fake id it generates to a real id. Also brings max acceleration structures per stage default down to one to align with metal.
Testing
Enables tests
Squash or Rebase?
Squash
Checklist
cargo fmt.cargo clippy --tests. If applicable, add:cargo xtask testto run tests.CHANGELOG.mdentry. Not really applicable